Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119373 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 92560 invoked from network); 20 Jan 2023 13:49:21 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 20 Jan 2023 13:49:21 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 11D08180538 for ; Fri, 20 Jan 2023 05:49:19 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 176.9.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 20 Jan 2023 05:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1674222555; bh=OXLK5ByoB0gmKhTQnjMksPru5er6ksZ07WCS6HmMe38=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kfjkcOG6FguF8p4D3/tmJHJSBGoDk3FskKugsPskOPH/2/h2NogWg1j3/NFZB1WEo kDy/Wt1rtVrE+3SHwUtUqv6OuuYhtK82BHdxeuVPFPRDIBEpuYHEF8MpD6nxKnCS0L Vs3dnwjl9YQ/TOpH0TiB4+4wtoUit6DDIMcw6afl2ViQpcGcngK28ByiHovkbjpYql aiOQAus46HAciprUwvyvIjL6ezYKwg2KID+yR38gsn1Bvk66q9ZyrDQaOzDgdKURlo Q7GtsEvyLG/zOm6jW0E3IYBsJwYNZC2Ht9ag6SgXlaAItl82PW/+idNyIIEo+rqL3G sKhswgHpy3Avw== Message-ID: Date: Fri, 20 Jan 2023 14:49:15 +0100 MIME-Version: 1.0 Content-Language: en-US To: Jakub Zelenka , Max Kellermann Cc: internals@lists.php.net References: <192ba7b6-dcf0-e2da-c99e-cbad40519e27@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] RFC: rules for #include directives From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=) Hi On 1/20/23 11:52, Jakub Zelenka wrote: >>> As it was said, this is problematic for bug fixes when merging up >>> and it's extra hurdle for maintainers - read this will slow down the >>> development. >> >> Can I do anything to help with those merges? >> >> > Reduce the diff to absolute minimum to prevent potential conflict. I think > it would be more acceptable if there was a plan that will get us there in > multiple releases rather than do one big bang change. Then devs more likely > remember what actually changed between releases and will be more careful > when merging up. A reasonable first step might be just *adding* all the missing '#include's to '*.c' with one PR per ext/* directory - not yet touching Zend/ and not adding a reasoning comment, because existing code doesn't have the reasoning comment either. Touching only *.c files in ext/ should not have any effect on anything else and thus adding those '#include's should be safe with regard to possible breakage. It might also be argued that such a missing include is an actual (hidden) bug. These PRs thus should be easy enough to review with a quick glance. Best regards Tim Düsterhus