Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119365 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 71494 invoked from network); 20 Jan 2023 11:00:31 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 20 Jan 2023 11:00:31 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 87D23180538 for ; Fri, 20 Jan 2023 03:00:27 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Fri, 20 Jan 2023 03:00:26 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 0742441294; Fri, 20 Jan 2023 12:00:26 +0100 (CET) Date: Fri, 20 Jan 2023 12:00:24 +0100 To: Michael =?utf-8?B?Vm/FmcOtxaFlayAtIMSMVlVU?= FJFI Cc: internals@lists.php.net Message-ID: References: <192ba7b6-dcf0-e2da-c99e-cbad40519e27@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [PHP-DEV] RFC: rules for #include directives From: max+php@blarg.de (Max Kellermann) On 2023/01/20 11:51, Michael Voříšek - ČVUT FJFI wrote: > I would highly appreciate if this could be done automatically, ie. > generate "the correct" includes and assert them by > https://github.com/php/php-src/blob/php-8.2.1/.github/actions/verify-generated-files/action.yml > CI. If you can generate the comments too, they can be asserted by CI > reliably then as well. Agree, it would be a good idea to integrate iwyu into the CI. (Of course, only if we agree that cleaning up those includes is a desired goal for the PHP project.) Max