Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119357
Message-ID: <2115758d-79e9-340e-ed7b-176dd0927c79@bastelstu.be>
Date: Thu, 19 Jan 2023 21:57:59 +0100
MIME-Version: 1.0
Content-Language: en-US
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: php internals <internals@lists.php.net>
References: <CAH5C8xUd4ueJ62pR6vT2haz9rFgrgspJQui1rPCqTneupD+tsQ@mail.gmail.com>
 <CADyq6sLFZpM1A+V-aa3dWjY1mL=65e-kxeiyBHABNPZR2GfpKQ@mail.gmail.com>
 <CAFPFaMKc-PQD8YD6yDWPrMONcJdYqFCXgyJZuZZBVsT7VSy89A@mail.gmail.com>
 <CADyq6sJxNQKvDNsT48tsG=AUS8snbGvuR332Yaip-krd+yynaQ@mail.gmail.com>
 <CAFPFaML4Xq7Oo+pN7cAj3aQt3y3et33EzsQhxhqNZA22nOUuNw@mail.gmail.com>
 <CADK1yXLSVH0X=dteA=GO+=UPSzSDfCecALytjRFG-u+0QRyGWg@mail.gmail.com>
 <a719c9d1-de30-41d2-b7ae-24dc53a57d90@app.fastmail.com>
 <CAH5C8xUer=mrRNYrdYpiYk6Z+nfaeZuacCJdAa3Oi8hyw97+Cg@mail.gmail.com>
In-Reply-To: <CAH5C8xUer=mrRNYrdYpiYk6Z+nfaeZuacCJdAa3Oi8hyw97+Cg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 1/19/23 09:01, Máté Kocsis wrote:
> As discussion apparently stalled, and since we managed to update the RFC
> with the recently brought up arguments, we would like to start the vote
> soon, possibly early next week, unless someone finds a new topic to discuss.

I'm confused by the linked PRs for the implementation, because they do 
not appear to match what's proposed. Specifically the one for proposal 
#2 (allow modification in __clone) appears to include unrelated changes 
(a clone-with{} syntax).

Also proposal #2 should be explicit about the behavior of unset(). It 
appears with the current implementation using unset() within __clone() 
is allowed and does what you expect it to do.

Best regards
Tim Düsterhus