Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119345 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 69367 invoked from network); 19 Jan 2023 10:29:24 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 19 Jan 2023 10:29:24 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id ED8DF1804B4 for ; Thu, 19 Jan 2023 02:29:23 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Thu, 19 Jan 2023 02:29:23 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 4BAB641314; Thu, 19 Jan 2023 11:29:22 +0100 (CET) Date: Thu, 19 Jan 2023 11:29:21 +0100 To: Kamil Tekiela Cc: internals@lists.php.net Message-ID: References: <8DA390C5-5E67-4847-A89F-1A8CCC6C5389@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] RFC: rules for #include directives From: max+php@blarg.de (Max Kellermann) On 2023/01/18 18:51, Kamil Tekiela wrote: > - I am against forward struct declarations. I think they decrease code > readability and should be avoided. btw. if this opinion is shared by the majority of voters, I'll send a PR to remove all existing forward declarations from PHP. There are many, for example zend_object_handlers in Zend/zend_types.h added by https://github.com/php/php-src/commit/c80e82230b5 Though one very interesting commit to introduce a forward declaration is https://github.com/php/php-src/commit/f4cfaf36e23ca (forward-declared zend_ast) > - I am against putting comments on #includes. Same here - there are currently 47 #includes with comments (none of which were written by me, some dating back 24 years ago). I'll take care of removing them all, if it turns out that the majority of voters doesn't like them. Max