Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119335
MIME-Version: 1.0
References: <CAFPFaMLtOAkRzTsqfdhvkZZ17JpUBg_WSQBpgVU6+xg-mLt2zA@mail.gmail.com>
 <alpine.DEB.2.23.453.2301181523100.23089@singlemalt.home.derickrethans.nl>
 <04288995-54CE-41A4-BFFD-A7CF72F16D3F@gmail.com> <CAGBsUreK46-tg6XZmykPJx2ap-fnKbLs0=NsjwTntxbbFK2E-Q@mail.gmail.com>
 <F0C029A9-76AF-459F-87AC-433770CE745C@gmail.com> <CABigaAXz+7g2moCjxRzpx_SZ=PdzzOvywmEw=0TKJmjXuSQEDg@mail.gmail.com>
 <A00D1DBC-01CE-469A-B722-C3BFF781B99C@gmail.com>
In-Reply-To: <A00D1DBC-01CE-469A-B722-C3BFF781B99C@gmail.com>
Reply-To: autaut03@gmail.com
Date: Wed, 18 Jan 2023 22:27:44 +0200
Message-ID: <CABigaAVC8W-Cpx5SO-SrS-q03Krg5yLaxc0a3gYGT1VWbORncA@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Kamil Tekiela <tekiela246@gmail.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e0050305f28fa68c"
Subject: Re: [PHP-DEV] [RFC] Path to Saner Increment/Decrement operators
From: autaut03@gmail.com (Alex Wells)

--000000000000e0050305f28fa68c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 18, 2023 at 10:09 PM Claude Pache <claude.pache@gmail.com>
wrote:

>
>
> Le 18 janv. 2023 =C3=A0 19:33, Alex Wells <autaut03@gmail.com> a =C3=A9cr=
it :
>
> Classes and methods is the expected way of implementing standard library
> in an OO language. New APIs (such as the new Random api) use OO instead o=
f
> functions and it makes more sense to use OO in this case too: there's
> likely a place for other methods too, like toBase(int $otherBase) etc. It
> would also be possible to use overloaded operators if needed.
>
>
> Fortunately, PHP is not (yet) a language where every problem requires the
> use and manipulation of objects implementing a generalised and unified
> solution. I guess that the OO way of writing:
>
> ```php
> function next_alpha_id(): string {
>     static $x =3D 'zz';
>     return ++$x;
> }
>
> function next_num_id(): int {
>     static $x =3D 0;
>     return ++$x;
> }
>
> $my_id =3D next_alpha_id();
> $my_other_id =3D next_num_id();
> ```
>
> would resemble to the following, except that `mixed` should be replaced b=
y
> the use of generics. For brevity, I left the mandatory interfaces as
> exercise to the reader.
>
> ```php
> class IdGenerator {
>
>     protected mixed $current;
>
>     public function __construct(
>         protected readonly IdGeneratorType $type
>       , protected readonly IdGeneratorDirection $direction
>       , mixed $start
>     ) {
>         $this->current =3D $start;
>     }
>
>     public function next(): mixed {
>         // implementation...
>     }
>
> }
>
> enum IdGeneratorType {
>     case alphabetic;
>     case numeric;
> }
>
> enum IdGeneratorDirection {
>     case positive;
>     case negative;
> }
>
>
>
> final class StandardGlobalAlphabeticIdGenerator {
>
>     private static IdGenerator $id_generator;
>
>     public static function get(): IdGenerator {
>         return self::$id_generator ?? new IdGenerator(
>             type: IdGeneratorType::alphabetic
>           , direction: IdGeneratorDirection::positive
>           , start: 'aaa'
>         );
>     }
>
> }
>
> final class StandardGlobalNumericIdGenerator {
>
>     private static IdGenerator $id_generator;
>
>     public static function get(): IdGenerator {
>         return self::$id_generator ?? new IdGenerator(
>             type: IdGeneratorType::numeric
>           , direction: IdGeneratorDirection::positive
>           , start: 1
>         );
>     }
>
> }
>
>
> $my_id =3D StandardGlobalAlphabeticIdGenerator::get()->next();
> $my_other_id =3D StandardGlobalNumericIdGenerator::get()->next();
> ```
>
> =E2=80=94Claude
>
>
You've overcomplicated your example, but the truth is that there's
sometimes a reason behind the complexity you might see. In this case your
functions will work right until you need two independent sequences, or you
need a backwards direction, or you need a sequence that can be seeded with
a "starting point". The point is not to have the "OO way" because someone
likes it, the point is to provide more flexibility, one that is likely to
be needed down the road.

In this case, a class like Number that accepts a specific $base in the
constructor will not hurt. There are definitely use cases for custom base
numbers as mentioned above and a class is just a better way of doing it
than trying to combine multiple concepts (base-10 ints, text strings and
custom base numbers) under one or two types and a bunch of functions on
top.

--000000000000e0050305f28fa68c--