Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119293
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Date: Tue, 17 Jan 2023 16:38:20 +0100
References: <CAFPFaM+d_1pV__2u+rkTEOF8mPM_CSXRk3udmG-+G1oVuKbQmg@mail.gmail.com>
 <CAOWwgpnJrHfx83wkd35J_9HwqzkB-1iRfTyqYbZ=7HB9nUhrhQ@mail.gmail.com>
 <CAFPFaMKTaQDSJXFfos=3sdL7ddSrje_aHWcg67GA9jXPe8uhew@mail.gmail.com>
 <22D992B7-62B3-4A4F-934F-17D53058FD35@cschneid.com>
 <CAFPFaM+M-g+YmsTaxzq9c-94AGNL=coxbtu4nn4ryvOPUtfsTg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CAFPFaM+M-g+YmsTaxzq9c-94AGNL=coxbtu4nn4ryvOPUtfsTg@mail.gmail.com>
Message-ID: <138CAD88-013E-40C7-8F0F-2034A7B0980B@cschneid.com>
Subject: Re: [PHP-DEV] [RFC] Add SameSite cookie attribute parameter
From: cschneid@cschneid.com (Christian Schneider)

Am 17.01.2023 um 15:59 schrieb G. P. B. <george.banyard@gmail.com>:
> Side-Note: Isn't SameSite a very generic name in the global namespace? =
I'm not sure what the PHP policy is here.
>=20
> AFAIK the global namespace is "owned" by PHP so that shouldn't be an =
issue per the usual policy.

In a quick check I could not find any other Enums defined in the core. =
Would this be the first one?

I guess I was comparing it to constants where in most cases the constant =
name reflects where it is used, e.g. STR_PAD_LEFT and I was therefore =
wondering whether the name SameSite should somehow contain cookie in one =
form or another. Or is this frowned upon for Enums?

> Are there any Enums in core PHP APIs where new values could be added =
in the future and how is the plan for code supporting multiple PHP =
version there? This was just something which crossed my mind when =
thinking about APIs with Enums. This is not really related to this RFC =
so I understand if you want to ignore this part :-)
>=20
> I might be again misunderstanding, but one cannot extend an enum as =
they are final classes under the hood.
> Currently, the only other native enum is the one that was added with =
the Randomizer Additions RFC [1] so this topic hasn't come up yet as the =
enum for ext-random is definetely complete.

I'm talking about adding new values in later PHP versions, let's for =
example assume they would add a SameSite mode "Stricter" and PHP wants =
to support that.
How would one write code to use "Stricter" in code meant to work for =
both old and new PHP versions?

- Chris