Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119289 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 84411 invoked from network); 16 Jan 2023 17:22:27 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 16 Jan 2023 17:22:27 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 399AA1804B0 for ; Mon, 16 Jan 2023 09:22:27 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_40,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 16 Jan 2023 09:22:26 -0800 (PST) Received: by mail-lj1-f171.google.com with SMTP id p25so24466166ljn.12 for ; Mon, 16 Jan 2023 09:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datadoghq.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hz0bG7ZNoXRhjXcIUK0zDN6uTsTAyYbkgqCZrUpp+/o=; b=GRbT8EUS4MXGRPoYGz63PoZGeN6ya7Ung/EBjUfjsebYsI9sVlJ6sfOjc6uTYyBfAB 0HA+HN7zLVjPPWZnvrVaVZYlZQiqu6+zqlkfH90G9T0Co9ieySEs9xFknMKzI6RvOEkR RVpKpIhM4n+HcJ+lhTwd1A9Pnj7KrfniM7ak4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hz0bG7ZNoXRhjXcIUK0zDN6uTsTAyYbkgqCZrUpp+/o=; b=2naGbjIm1NUG/K7iyx1n1XMu8+QqCk5RmBvTemZfhkRb/3k1Ib7ghZDKPdoa0DcjY8 rLvWj1/FZOCNETJHLYbVxkeeXW9xZbojVPOwGxZSZD2MD3yzm5od5uFPCs+/MTdSN6Fd 9H1dBj5Kgdgev55ixaHFOkDZ4JzWlJ2ip9SgZnhp8G4XaZkqaR7nyR2Ws2CZmCT8pRDf ttt69VZk8O9AOlfa/0EpPkpBge8l+7ZFNJZxC+sTaB6ylXlA05l14OutorLo7/QOkKeu 34sz928CMu6bJO4MahhmDKsXWvfDkDfoBlWInxGptbob0X7S6WkfuzcEx2lYvvDs3iAB 930w== X-Gm-Message-State: AFqh2krVC32KBsS0Lagu+xFoBdml4z3jepYGQ/xhOiXVvQNZ6N8yIG/Y pzEDSDW8DJ6m25iBcVS+bbX3V6MZEIHVcj/HpcS0pMO4xYza2Q== X-Google-Smtp-Source: AMrXdXsIw7CRQHOfhM65omOy63BDW2qwj1iTfgCvcgZd0uL3HqJ2D7Nl7S7XJSbC+uTPmQhSCRQYtuuoZ5dRP8RC65o= X-Received: by 2002:a2e:7c02:0:b0:287:86c:59d9 with SMTP id x2-20020a2e7c02000000b00287086c59d9mr30995ljc.524.1673889745231; Mon, 16 Jan 2023 09:22:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: Levi Morrison Date: Mon, 16 Jan 2023 10:22:14 -0700 Message-ID: To: Max Kellermann Cc: internals@lists.php.net Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] RFC: rules for #include directives From: internals@lists.php.net ("Levi Morrison via internals") As commented yesterday on one of the PRs, I strongly agree with the cleanups. Our code has implicit dependencies and if you reorder the includes in the same file, you can break builds. That shouldn't ever happen. I also agree that dtrace breaking is a failure of CI and testing, not necessarily the patch (I haven't reviewed that PR carefully, maybe there was some carelessness but if it's not tested, it's hard to blame anyone). Lastly, I do not care for the comments which explain why a header is included. My experience is that these comments bitrot quite quickly. Overall, I hope we can resume this effort.