Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119287 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 79125 invoked from network); 16 Jan 2023 16:44:40 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 16 Jan 2023 16:44:40 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 4F436180559 for ; Mon, 16 Jan 2023 08:44:40 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 176.9.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 16 Jan 2023 08:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1673887479; bh=8Ti0by0+ArZmFtNSikmp9vwlLpLP2uP/B7BHq2p3t5A=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=XP0eUbuw+7bo9gOha5KuvcbxRqCe9x0DVIw9ZT2qy5MwtIZT5AEdUOI29rZKXwj2v undw54/JkhLhxA+SbCXGfJEGqMV4vcetMom0JIdoMuhrpzDuA7lOFzjcGLJVpt6LFP 8j2F89dNC76KuNLF+VO1MyN/eN/XU5wenalXzEdW7btex7ILOWO3p3RtQHi8KNAS95 jGAEctXQGRRYPcmjCuCxGD4/jMucuYWesVcMf+f7v6ix6NKAOdN8GnPuupPy7ilni4 6AC/qZZHAbhpgrChPWcAKuRvSzmUP2ok6/MpOFFor4pPnsksqNrMZXloiExVTi2KB/ 7bqUUasOzk+wQ== Message-ID: <789f13d7-f940-61f8-914f-f4fcc8a72569@bastelstu.be> Date: Mon, 16 Jan 2023 17:44:38 +0100 MIME-Version: 1.0 Content-Language: en-US To: Kamil Tekiela , Max Kellermann Cc: Chase Peeler , internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] RFC: rules for #include directives From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=) Hi On 1/16/23 17:36, Tim Düsterhus wrote: > From my experience contributing to another C project (HAProxy), > cleaning up the the includes can have a measurable impact on build > times. See this commit for example: Sorry for the duplicate mail, but it just came to my mind checking the CI build logs from before and after the revert: ------------- Before (x64 Release ZTS) https://github.com/php/php-src/actions/runs/3924250312/jobs/6708385711 After: https://github.com/php/php-src/actions/runs/3929927482/jobs/6719316931 9:26 minutes -> 9:52 minutes Before (x64 Debug NTS): https://github.com/php/php-src/actions/runs/3924250312/jobs/6708385677 After: https://github.com/php/php-src/actions/runs/3929927482/jobs/6719316800 4:14 minutes -> 5:11 minutes ------------- So with the changes that already happened, Max managed to shave off 30 seconds (5%) for the x64 Release ZTS build and 1 minute (19%) for the x64 Debug NTS build. This difference would likely become even larger, as to my understanding the cleanup wasn't complete yet. Best regards Tim Düsterhus