Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119286
Date: Mon, 16 Jan 2023 17:43:22 +0100
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: internals@lists.php.net
Message-ID: <Y8V+qoW3Nfspzx4K@swift.blarg.de>
References: <Y8U9B4AVP/R7vazI@swift.blarg.de>
 <CAGBsUrdQAXE2qk_UDQY9v6pYpWH+=bX6S3ou+sttQamtDC1F9A@mail.gmail.com>
 <Y8VI5yanzli8D4Cm@swift.blarg.de>
 <CAPKYkKyea-BFg94nyh-DHNLZuwQrEuJ2HR4D8kYKktfsj=f8sQ@mail.gmail.com>
 <Y8V59WHuibw33ayJ@swift.blarg.de>
 <CAGBsUrdYnwU8He-0gR0bM04X7KvGShsrQHL3D97mW4CczpyDpw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGBsUrdYnwU8He-0gR0bM04X7KvGShsrQHL3D97mW4CczpyDpw@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC: rules for #include directives
From: max+php@blarg.de (Max Kellermann)

On 2023/01/16 17:25, Kamil Tekiela <tekiela246@gmail.com> wrote:
> Have you done any benchmarking in terms of build time? Is there any
> tangible difference or is it only theoretical?

I did, but in this early stage, there is no measurable speedup yet,
because there are still too many "fat" headers left that need to be
included everywhere, which in turn include too much.  The many small
improvements I made so far drown in that noise.

Once I have disentangled and splitted those fat headers (e.g. move
zend_result to a separate header to avoid including zend_types.h
everywhere), the speedup will be measurable and perceptible.  It's too
early to prove it with numbers.