Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119285
Message-ID: <dd911479-7bc1-f334-369c-3ba7044651cf@bastelstu.be>
Date: Mon, 16 Jan 2023 17:36:09 +0100
MIME-Version: 1.0
Content-Language: en-US
To: Kamil Tekiela <tekiela246@gmail.com>, Max Kellermann <max+php@blarg.de>
Cc: Chase Peeler <chasepeeler@gmail.com>, internals@lists.php.net
References: <Y8U9B4AVP/R7vazI@swift.blarg.de>
 <CAGBsUrdQAXE2qk_UDQY9v6pYpWH+=bX6S3ou+sttQamtDC1F9A@mail.gmail.com>
 <Y8VI5yanzli8D4Cm@swift.blarg.de>
 <CAPKYkKyea-BFg94nyh-DHNLZuwQrEuJ2HR4D8kYKktfsj=f8sQ@mail.gmail.com>
 <Y8V59WHuibw33ayJ@swift.blarg.de>
 <CAGBsUrdYnwU8He-0gR0bM04X7KvGShsrQHL3D97mW4CczpyDpw@mail.gmail.com>
In-Reply-To: <CAGBsUrdYnwU8He-0gR0bM04X7KvGShsrQHL3D97mW4CczpyDpw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC: rules for #include directives
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 1/16/23 17:25, Kamil Tekiela wrote:
> Have you done any benchmarking in terms of build time? Is there any
> tangible difference or is it only theoretical?
> 

 From my experience contributing to another C project (HAProxy), 
cleaning up the the includes can have a measurable impact on build 
times. See this commit for example:

https://github.com/haproxy/haproxy/commit/340ef2502eae2a37781e460d3590982c0e437fbd

They go even as far as regularly reordering object files by build time 
to optimally keep multi-core machines busy to shave off the last few 
milliseconds:

https://github.com/haproxy/haproxy/commit/d2ff5dc3ebba1163749e2d874cce5892570f540a

Even for incremental build having a hypothetical 100ms decrease in build 
time can make the difference between "this is fast enough to wait" and 
"this is so slow that my mind wanders around while waiting to build". 
And in CI which doesn't do incremental builds we won't needlessly burn 
CPU time that is better spent elsewhere.

Thus I'm in favor of this cleanup.

Best regards
Tim Düsterhus