Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119261 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 54373 invoked from network); 11 Jan 2023 14:19:14 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 11 Jan 2023 14:19:14 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id CF89E180511 for ; Wed, 11 Jan 2023 06:19:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15623 212.45.192.0/19 X-Spam-Virus: No X-Envelope-From: Received: from mail.gna.ch (mail.gna.ch [212.45.196.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 11 Jan 2023 06:19:10 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by darkcity.gna.ch (Postfix) with ESMTP id F29393A1D87 for ; Wed, 11 Jan 2023 15:19:08 +0100 (CET) X-Virus-Scanned: amavisd-new at example.com Received: from mail.gna.ch ([127.0.0.1]) by localhost (darkcity.gna.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PGsAJ88XNDlF for ; Wed, 11 Jan 2023 15:19:08 +0100 (CET) Received: from smtpclient.apple (unknown [IPv6:2a02:1210:2ea4:cf00:141:55bb:a7cb:10c8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by darkcity.gna.ch (Postfix) with ESMTPSA id 3E44B3A1D85 for ; Wed, 11 Jan 2023 15:19:08 +0100 (CET) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Date: Wed, 11 Jan 2023 15:19:07 +0100 References: <3FBD0CCD-BCF2-4B90-BD4C-AD651D1F7C60@cschneid.com> To: "internals@lists.php.net" In-Reply-To: Message-ID: <69F6381E-931A-43A5-AED4-5BF9F742A329@cschneid.com> X-Mailer: Apple Mail (2.3731.300.101.1.3) Subject: Re: Adding strtotime change to migration document From: cschneid@cschneid.com (Christian Schneider) Am 11.01.2023 um 15:04 schrieb Christoph M. Becker : > On 11.01.2023 at 14:07, Christian Schneider wrote: >=20 >> While migrating to PHP 8.2 we noticed the change in strtotime. >> PHP <=3D 8.1 supported "today +- 3 days" etc. but the support for = multiple sign characters (++, --, -+, +-) has been removed in 8.2: >> https://3v4l.org/mHa3t >>=20 >> This was discussed at >> https://github.com/php/php-src/issues/9950#issuecomment-1314101723 >>=20 >> I understand the reasoning to remove support even though I liked the = flexibility but as this is a small BC break I was wondering if it should = be added to the migration document for 8.2. >=20 > Given that PHP itself has no problems with this > (), I think a changelog entry is appropriate. > Maybe you want to provide a respective PR? I'm not familiar with the changelog / migration document handling but my = preferred place would be a line in the migration document so people = checking what they have to look out for hopefully see it. I don't think = people read the full changelogs. - Chris