Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119249
Date: Mon, 09 Jan 2023 21:42:24 +0000
To: internals@lists.php.net, Sara Golemon <pollita@php.net>,
 PHP internals <internals@lists.php.net>
User-Agent: K-9 Mail for Android
In-Reply-To: <CAESVnVo3NyM_RGybyLQSko0F=fBSnSWG3gkVZtU-DS8W=79fdA@mail.gmail.com>
References: <CAESVnVo3NyM_RGybyLQSko0F=fBSnSWG3gkVZtU-DS8W=79fdA@mail.gmail.com>
Message-ID: <A93F2A9D-BA70-4C0D-8496-581B0DA0C829@derickrethans.nl>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] base64url format
From: derick@derickrethans.nl (Derick Rethans)

On 9 January 2023 18:49:28 GMT, Sara Golemon <pollita@php=2Enet> wrote:
>I've been working with JWTs lately and that means working with Base64URL
>format=2E (Ref: https://www=2Erfc-editor=2Eorg/rfc/rfc4648#section-5 )
>This is essentially the same thing as normal Base64, but instead of '+' a=
nd
>'/', it uses '-' and '_', respectively=2E It also allows leaving off the
>training '=3D' padding characters=2E
>
>So far, I've just been including polyfills like this:
>
>function base64url_decode(string $str): string {
>    return base64_decode(str_pad(strtr($str, '-_', '+/'), (4 -
>(strlen($str) % 4)) % 4, '=3D'));
>}
>
>function base64_encode(string $str): string {
>    return rtrim(strtr(base64_encode($str), '+/', '-_'), '=3D');
>}
>
>These work fine, but they create a LOT of string copies along the way whi=
ch
>shouldn't be necessary=2E
>Would anyone mind if skipped RFC and just added `base64url_encode()` and
>`base64url_decode()` to PHP 8=2E3?

Should these be new functions, or options to base64_encode instead? I'd gu=
ess base64_decode could just accept both?=20

cheers=20
Derick=20