Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119235
MIME-Version: 1.0
References: <0854b030-c51c-4c1b-a7dd-22835a1e5da9@app.fastmail.com>
 <CA+kxMuT2uXLy_GSiOa-XCHT5XE5xOHew7CkDev3obKjt7y08Qw@mail.gmail.com> <411c8b54-78c2-4e67-91da-cd2f2dab88aa@app.fastmail.com>
In-Reply-To: <411c8b54-78c2-4e67-91da-cd2f2dab88aa@app.fastmail.com>
Date: Thu, 5 Jan 2023 20:18:42 +0000
Message-ID: <CA+kxMuRTL=aTspQfm5Q5sP8x0E_ZZOXgCzr4TJYGXFteBdK8Ew@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, with readonly
From: Danack@basereality.com (Dan Ackroyd)

On Fri, 25 Nov 2022 at 00:07, Larry Garfield <larry@garfieldtech.com> wrote=
:
>
> On Sun, Nov 20, 2022, at 7:20 AM, Dan Ackroyd wrote:
> > Hi Larry,
> >
> > Regarding the syntax, up until now PHP has only supported the letters
> > a-z and underscore in keywords.
> >
> > I realise this is an aesthetic thing, but "private(set)" looks like a
> > function to me, and not a keyword. I saw the previous poll, and it
> > didn't include options for either protected_set/private_set or
> > protectedset/privateset.
> >
> > Was there a technical reason for excluding them as an option?
>
> Not in particular.  We originally proposed `private(set)` because that's =
what Swift uses.  In the discussion people proposed several alternatives th=
at I put into the poll, but `private_set` wasn't one of them.  Although sev=
eral people said they were opposed to parens in the keyword,

Have you considered updating the RFC to use private_set, and not
introduce new characters for keywords?

As it wasn't in the poll, then sticking to the poll result with at
least some people saying they are opposed to it seems not necessarily
the correct choice. The ()'s look particularly funky to me with
property promotion.

cheers
Dan
Ack