Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11919 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74811 invoked by uid 1010); 4 Aug 2004 21:26:10 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 74787 invoked from network); 4 Aug 2004 21:26:09 -0000 Received: from unknown (HELO lisa.elitel.it) (212.34.224.193) by pb1.pair.com with SMTP; 4 Aug 2004 21:26:09 -0000 Received: (qmail 81856 invoked from network); 4 Aug 2004 21:26:08 -0000 Received: from unknown (HELO astrid.santinoli.com) (212.34.243.106) by lisa.lombardiacom.it with SMTP; 4 Aug 2004 21:26:08 -0000 Received: by astrid.santinoli.com (Postfix, from userid 502) id E5B754816B; Wed, 4 Aug 2004 21:54:15 +0200 (CEST) Date: Wed, 4 Aug 2004 21:54:15 +0200 To: internals@lists.php.net Message-ID: <20040804195415.GA15482@astrid.santinoli.com> References: <20040804145657.GA15294@astrid.santinoli.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Fastpath Research User-Agent: Mutt/1.5.6i Subject: Re: [PHP-DEV] [PATCH] Passthrough MD5/SHA1 calculation of uploaded files From: u235@libero.it (David Santinoli) On Wed, Aug 04, 2004 at 05:06:45PM +0200, Derick Rethans wrote: > > I like this idea, and the patch looks (from a glance OK). Without > applying it I have a question though: > > Does it handle cleaning up the digest structures correctly if the > fileupload is aborted in some way? Do you refer to the PHP_MD5_CTX and PHP_SHA1_CTX contexts? AFAIK, given they're automatic variables with no malloc()ed buffers inside them, it doesn't look like an explicit cleanup is needed. Cheers, David PS I'm on the list! CC:ing to my private address is unnecessary. -- David Santinoli, Milano + Independent Linux/Unix consultant + http://www.santinoli.com