Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:11916
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Reply-To: ilia@prohost.org
To: dave@php.net,
 internals@lists.php.net
Date: Wed, 4 Aug 2004 11:35:17 -0400
User-Agent: KMail/1.6.1
References: <20040804145657.GA15294@astrid.santinoli.com> <200408041108.22045.ilia@prohost.org> <4110FDD4.2060106@php.net>
In-Reply-To: <4110FDD4.2060106@php.net>
Organization: Prohost.org
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-ID: <200408041135.17954.ilia@prohost.org>
Subject: Re: [PHP-DEV] [PATCH] Passthrough MD5/SHA1 calculation of uploaded files
From: ilia@prohost.org (Ilia Alshanetsky)

On August 4, 2004 11:16 am, Dave wrote:
> I think his point was that the hash is calculated as the file is being
> uploaded, which saves having to read the whole file a second time after
> uploading is finished. For big files, and repetitious uploading, this
> could probably save on the CPU cycles and I/O load a bit.

That is true, but to really validate the file you'd still want to check the 
data you have on disk, rather then what PHP supposedly saved to disk.

Adding hidden fields (that may conflict with the ones some people already use) 
also seems like a recipe for trouble.

Ilia