Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119152
Message-ID: <cfc22ee4-b229-f580-5fa8-1ab786160a7d@bastelstu.be>
Date: Thu, 15 Dec 2022 17:40:09 +0100
MIME-Version: 1.0
Content-Language: en-US
To: Derick Rethans <derick@php.net>,
 PHP Developers Mailing List <internals@lists.php.net>
References: <alpine.DEB.2.23.453.2212151531360.462551@singlemalt.home.derickrethans.nl>
In-Reply-To: <alpine.DEB.2.23.453.2212151531360.462551@singlemalt.home.derickrethans.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Unicode Text Processing
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 12/15/22 16:34, Derick Rethans wrote:
> You can find it at:
> https://wiki.php.net/rfc/unicode_text_processing
> 
> I'm looking forwards to hearing your opinions, additions, and
> suggestions — the RFC specifically asks for these in places.

Some first remarks:

----------

replaceText():

In the replaceText() section the description refers to a non-existent 
parameters '$maxReplacements' and '$collator'. Also the second paragraph 
in that section looks like a word is missing there.

----------

getPositionOfFirstOccurrence():

I agree this is too long. How about:

- findOffset()
- findOffsetLast()

And for returnFromFirstOccurence():

- startingWith()
- startingWithLast()

----------

firstToTitle():

I don't see how this differs from toTitle() and/or firstToUpper(). An 
example would likely be helpful.

----------

wordsToTitle():

Likewise.

----------

The return of many methods is not explicitly listed. I'd put it 
everywhere to make it 100% clear that all those functions return 'Text'.

Best regards
Tim Düsterhus