Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119144 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 1836 invoked from network); 14 Dec 2022 20:04:30 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 14 Dec 2022 20:04:30 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 0473C1804FF for ; Wed, 14 Dec 2022 12:04:30 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_05, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 14 Dec 2022 12:04:29 -0800 (PST) Received: by mail-qk1-f177.google.com with SMTP id pe2so1759236qkn.1 for ; Wed, 14 Dec 2022 12:04:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d5NvoOrcnA4zm11ro0dZTF30PFuN656SN5ORBtxu5HA=; b=v8dV2UVshUxWUaGqcKretiP9EwKRs8CRDSNEwh3Ao06BcWdVI7zH/87vWUWPXEvEXM i8+PQt4rYFURR/3BHAfGBnkYgOmyYr7jNYa+6gOjb9HH7B21iNNMoQUk1B9aqhVoUcSH 11rdlTWUSQEH0cg2nFHRBVauS4UGTBJQCxg2bpXwN3Ph+SbT3GA6vQzXcLiCvAzI7BeX Z+yyVhvCi77o2kxbWuY0Jo+cpnpZJJ1f0mUnGkfbCn1KsLxazuixc1d8Vg4H8vZiGGoj zPOKpf2YyO9TPbChkWKL1zIERpcvkE02ubQ4yF64SDU51nlksBYAk1h7lk7YvUpmObTf G5RA== X-Gm-Message-State: ANoB5pm/pR+VRJFHPa+c9c4lC/tpnHk9tZjCgweGE0N5p3kb400GzQ7X xcbnWMwuJKTyf4yDyfYFsg3BshoQit52XG9zZ7xI69ui8WMBX+nM X-Google-Smtp-Source: AA0mqf7YRIUuwoDlK7CLsXyKnRdLIawZjyrtxMIuyBPJHY/S6w1MI9lBX6XhVxOO8wWXIKSIa1dmYrHiNO6hYHkUP3s= X-Received: by 2002:ae9:c217:0:b0:6fc:9203:83fd with SMTP id j23-20020ae9c217000000b006fc920383fdmr35336095qkg.167.1671048268837; Wed, 14 Dec 2022 12:04:28 -0800 (PST) MIME-Version: 1.0 References: <4c1e58ca94c3069b8704b7068254fe3926c5ad17ab62bf88bfed79de0c62bd10@mahalux.com> In-Reply-To: Date: Wed, 14 Dec 2022 14:04:18 -0600 Message-ID: To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= Cc: =?UTF-8?B?TWljaGFlbCBWb8WZw63FoWVrIC0gxIxWVVQgRkpGSQ==?= , internals@lists.php.net Content-Type: multipart/alternative; boundary="000000000000778c6d05efcf3ec4" Subject: Re: [PHP-DEV] Remove PHP-x.y.* git branches From: pollita@php.net (Sara Golemon) --000000000000778c6d05efcf3ec4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2022 at 12:03 PM Tim D=C3=BCsterhus wrot= e: > One benefit of removing those branches would be, that usability of > GitHub's branch selector improves, specifically the branch selector when > creating a new PR. > Maybe this is my CLI privilege talking, but who's using pulldowns to select PR branches? Sepcifically, IME we tend to get PRs against the `master` branch. All that aside, I do agree that the dropdown's contents can be daunting. It's a big list. But: 1/ We're unlikely to get rid of the release branches 100%. The current RC cycles have branches for their release so that we can add revisions onto the RC and get a stable final. So at minimum, there's going to be a release branch in place for each active release on 16 out of 28 days (slightly more than 50% of the time). Sure, that's just a couple of version specific branches instead of hundreds, and that point is well taken, but my counterpoint is that we will have working branches. 2/ I'm not convinced this is a confusing scheme. While php-src doesn't follow perfect semver, we certainly have something recognizable to the broader OSS development community, and if you see PHP-8.0 PHP-8.0.0 PHP-8.0.1 etc... I think a programmer is going to being able to sus out the meaning of these branches. Even if they don't, the review process will easily be able to set them straight. TL;DR We can expect a reasonable amount of sense on the part of anyone who has any reason to be poking around branches. Given #2, I don't see a significant benefit, given #1 I see that benefit being naturally mitigated, and I don't see removing data from our repo as being valuable. Just my personal feeling on the matter, don't let me discourage you from bringing this to an RFC and holding a vote. -Sara --000000000000778c6d05efcf3ec4--