Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119119
Message-ID: <ecef4c97-5508-bf0b-a5e1-7f3df645d91a@gmail.com>
Date: Tue, 13 Dec 2022 13:52:31 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Content-Language: en-GB
To: internals@lists.php.net
References: <CAMXcktOiFH-0f0PG9cKkkVaczjNLSzQzzPUBcoLyn54X=c74og@mail.gmail.com>
 <D494A14E-0733-406B-844E-DD2D3FBB7EB4@php.net>
 <CAMXcktNEW9ZyvzOdseaz3yu7zLAKq5LrF74=FAk62BTbF+0qFQ@mail.gmail.com>
In-Reply-To: <CAMXcktNEW9ZyvzOdseaz3yu7zLAKq5LrF74=FAk62BTbF+0qFQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Revisiting RFC: Engine Warnings -- Undefined array
 index
From: rowan.collins@gmail.com (Rowan Tommins)

On 13/12/2022 12:53, Dan Liebner wrote:
> It breaks my app. Does that count?


The only way a Warning can break an application is if you're running a 
custom handler which promotes it to an error. If that is your case, then 
blaming PHP is a little bit like programming your car to do an emergency 
stop at every road sign, then complaining to the highways agency when 
someone runs into the back of you.

On the other hand, in keeping with my earlier suggestion of making valid 
use cases easy, PHP could help by making it easier to filter messages in 
that callback. At the moment, you'd have to match the content of the 
message, which is not ideal; a unique code for each message type would 
be much nicer, but there's potentially quite a lot of initial work to 
assign codes to all the existing messages.

That way, you could promote some warnings to errors, and ignore others; 
or log them with your own choice of severity, possibly not even limiting 
yourself to those that PHP provides.

Of course, this won't help in the long run for things which eventually 
do become errors, but for everything below that level, it would be much 
more powerful than a one-off setting to change the severity of one 
specific message.

Regards,

-- 
Rowan Tommins
[IMSoP]