Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11911 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26792 invoked by uid 1010); 4 Aug 2004 15:06:48 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26758 invoked from network); 4 Aug 2004 15:06:48 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 4 Aug 2004 15:06:48 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i74F6lE7027313 for ; Wed, 4 Aug 2004 17:06:47 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i74F6jA6027301; Wed, 4 Aug 2004 17:06:45 +0200 Date: Wed, 4 Aug 2004 17:06:45 +0200 (CEST) X-X-Sender: derick@localhost To: David Santinoli cc: internals@lists.php.net In-Reply-To: <20040804145657.GA15294@astrid.santinoli.com> Message-ID: References: <20040804145657.GA15294@astrid.santinoli.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] [PATCH] Passthrough MD5/SHA1 calculation of uploaded files From: derick@php.net (Derick Rethans) On Wed, 4 Aug 2004, David Santinoli wrote: > I'm submitting a patch to perform "on the fly" MD5/SHA1 digest > calculation of a file uploaded via the HTTP POST method. Being > not uncommon for applications to require some digest of a freshly > uploaded file, doing the math directly in the buffer where the file is > being read can save some time. I like this idea, and the patch looks (from a glance OK). Without applying it I have a question though: Does it handle cleaning up the digest structures correctly if the fileupload is aborted in some way? regards, Derick