Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119091
To: "'Ilija Tovilo'" <tovilo.ilija@gmail.com>,
	"'PHP internals'" <internals@lists.php.net>
References: <CAPyj-LB5cYi7Z5oJkTA88AdCRAKvtxstbAtmqTM6L31qxtp8Lw@mail.gmail.com>
In-Reply-To: <CAPyj-LB5cYi7Z5oJkTA88AdCRAKvtxstbAtmqTM6L31qxtp8Lw@mail.gmail.com>
Date: Tue, 6 Dec 2022 02:52:16 +0800
Message-ID: <006901d908da$b23b3e20$16b1ba60$@jhdxr.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJjnaxR2v5He4x+QM1VAPNMA9je+q1KcHEQ
Content-Language: zh-cn
Feedback-ID: Yeas:jhdxr.com:qybglogicsvr:qybglogicsvr5
Subject: RE: [PHP-DEV] [RFC][List/Assoc\unique]
From: me@jhdxr.com (=?utf-8?b?Q0hVIFpoYW93ZWk=?=)

Hi Ilija,

Thanks for the RFC. In general, I like the idea but there are certain =
things not clear to me.

1. What will happen if we pass a list to ` Assoc\unique`?=20
```
Assoc\unique([1, 2, 3, 1]);
```

2. What will happen if the array (no matter list or assoc) contains pure =
value and reference which are strict equal? As the RFC says "references =
are preserved."=20
```
$a =3D 1;
$arr1 =3D [$a, &$a];
$arr2 =3D [&$a, $a];
List\unique($arr1);
List\unique($arr2);
```

3. Currently the RFC (proposal section, function signature) claims the =
parameter are bool type, which is obvious wrong. But this is just a =
minor mistake, what I really want to ask here is do we support array =
only or any array like input?

> Side note: I *really* hope the discussion will be about more than just =
the namespaces.

Adding two new namespaces with single function doesn't look good to me, =
especially I cannot think of anything that we may add to these two =
namespace in the future.

Regards,
CHU Zhaowei