Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119072
Message-ID: <355b4e04-546d-c587-8da3-05b22001fb89@bastelstu.be>
Date: Thu, 1 Dec 2022 19:38:44 +0100
MIME-Version: 1.0
Content-Language: en-US
To: Ilija Tovilo <tovilo.ilija@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAPyj-LB5cYi7Z5oJkTA88AdCRAKvtxstbAtmqTM6L31qxtp8Lw@mail.gmail.com>
In-Reply-To: <CAPyj-LB5cYi7Z5oJkTA88AdCRAKvtxstbAtmqTM6L31qxtp8Lw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC][List/Assoc\unique]
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 12/1/22 19:22, Ilija Tovilo wrote:
> https://wiki.php.net/rfc/list_assoc_unique
> 
> This RFC proposes adding two new functions, List\unique() and
> Assoc\unique() as alternatives using strict equality (===) semantics,
> the former discarding and the latter preserving keys.


I believe this would be better solved as part of the more generic 
"expanded iterable helper functions" proposal (which I really hope makes 
it into a proper RFC that is accepted):

https://externals.io/message/118896

Deduplication is reasonably well-defined for arbitrary iterators (even 
infinite iterators) and I don't think iterators (esp. Generators) should 
remain second-class citizens to arrays going forward.

> Side note: I *really* hope the discussion will be about more than just
> the namespaces.
> 

In addition to the reasons above: Yes, adding two new single-function 
namespaces IMO is not a good thing, because it only adds to the 
inconsistency. Adding new namespaces should be part of a "bigger picture".

Best regards
Tim Düsterhus