Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119034
MIME-Version: 1.0
References: <CAH5C8xUd4ueJ62pR6vT2haz9rFgrgspJQui1rPCqTneupD+tsQ@mail.gmail.com>
 <CADyq6sLFZpM1A+V-aa3dWjY1mL=65e-kxeiyBHABNPZR2GfpKQ@mail.gmail.com>
In-Reply-To: <CADyq6sLFZpM1A+V-aa3dWjY1mL=65e-kxeiyBHABNPZR2GfpKQ@mail.gmail.com>
Date: Sat, 26 Nov 2022 20:45:10 +0100
Message-ID: <CAH5C8xW1QZCtMwaOzGWj36e+60aMoTx6sJPB5B8826RFXFZiow@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ec831d05ee64e0c5"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000ec831d05ee64e0c5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Marco,

Sorry for the very late reply!

As explained in
> https://github.com/lcobucci/jwt/pull/979#discussion_r1025280053, a
> consumer relying on a `readonly`
>
implementation of a class probably also expects replacement implementations
> as read-only.
> I am aware that we lack the `readonly` marker at interface level (would b=
e
> really neat), but the practical example is as follows:
>

Regarding readonly interfaces: it would be a good idea given properties
were be able to be declared in interfaces. Then readonly
interfaces could adopt the same semantics as readonly classes have, so that
all *declared* properties become readonly.

Regarding the LSP violation: your example is about immutability (as the
name of the classes also suggest), but the readonly
keyword doesn't guarantee immutability. This is basically what Nicolas
answered not long ago to Larry:
https://externals.io/message/118554#118604

readonly class FancyPerson extends Person {
>     private readonly stdClass $middle;


>     public function setMiddle(string $mid) {
>         $this->middle ??=3D new stdClass;
>         $this->middle->name =3D $mid;
>     }


>     public function fullName() {
>         return "$this->first $this-middle $this->last";
>     }
> }


We proposed this change because it wouldn't break anything that's already
not "broken".

Regards:
M=C3=A1t=C3=A9

--000000000000ec831d05ee64e0c5--