Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119032
MIME-Version: 1.0
References: <CADDxozmK-qb37v1fE_j92UmO_y9XB2dt3rOmVxY4GdfUXwnoPg@mail.gmail.com>
 <42A5DAC6-253E-478D-808C-36690FA88315@gmail.com> <CADDxoz=z2kQsx2cq5FxQyBM4r+zDOcAoK035RqM811PB13CWfA@mail.gmail.com>
 <CAEKnhAEmDB6fq7wFs=q965ZmzP-r7mRuOHM1F5DG4-OAsTjNhg@mail.gmail.com>
 <46b289c4-9255-ad66-3410-46b19fc91bf6@gmail.com> <CAFv4g+EPjGd06wnQ448UxL28FnwRGR9Ybf0fJYhpBH-EZfEhxA@mail.gmail.com>
In-Reply-To: <CAFv4g+EPjGd06wnQ448UxL28FnwRGR9Ybf0fJYhpBH-EZfEhxA@mail.gmail.com>
Reply-To: Mikhail Galanin <mikhail.galanin@team.bumble.com>
Date: Fri, 25 Nov 2022 14:01:04 +0000
Message-ID: <CADDxoznOKS=EFoUG_W=S6Po+tkBe3y+fEgQ_w3ApJFinOykAxQ@mail.gmail.com>
To: Craig Francis <craig@craigfrancis.co.uk>
Cc: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Microseconds to error log
From: internals@lists.php.net ("Mikhail Galanin via internals")

Hello good people,

(really hope I'm writing into the right thread this time).

I updated the patch considering the thoughts from this thread. Thank
you all for being so much responsive and helpful!

Meanwhile, there are two changes:

* Added function `php_format_timestamp' that takes microseconds part,
`php_format_date' remains unchanged to keep backward compatibility.
* Added INI `error_log_usec` = on|off (off by default) that changes
the timestamp.


Questions I have at the moment:

1. Naming (the most difficult part of our job, yeah) - does anyone
feel that they could suggest something better? Maybe someone can think
up something better, more clear/consistent with other parts of the
codebase?

2. The INI-thing. When initially I mentioned being configurable, I
realised that it could've been perceived in many different ways:

- we can enable/disable the microseconds
- we can choose from a pre-defined list of formats (PHP7, PHP7 + msec,
PHP7+ usec, ISO8601, ISO8601+usec, etc...)
- we also might want to use an Apache/HTTPd-like approach, e.g.
"[${time:format} $pid $hostname] $error_message"

Or, once we enable microseconds, we can switch to the ISO format, for
example (no, I don't like this approach but if we change the setting
name it might be not that confusing)

What do you think?

On Mon, Oct 31, 2022 at 10:16 AM Craig Francis <craig@craigfrancis.co.uk> wrote:
>
> On Sun, 30 Oct 2022 at 17:42, Rowan Tommins <rowan.collins@gmail.com> wrote:
>
> > In case of any confusion, I think this should be configurable as
> > "include microseconds: on / off", not configurable as "enter date format".
> >
>
>
> Any reason it can't be configured to use ISO 8601?
>
> Apache 2.4 allows you to use `LogFormat "...
> [%{%Y-%m-%dT%H:%M:%S}t.%{msec_frac}t] ..." format_name`
>
> https://httpd.apache.org/docs/trunk/mod/mod_log_config.html
>
> And MySQL uses "YYYY-MM-DDThh:mm:ss.uuuuuu":
>
> https://dev.mysql.com/doc/refman/8.0/en/error-log-format.html#error-log-format-system-variables
>
> When I'm doing some quick log checking, I often forget that PHP uses a
> different date format... admittedly, it can help having the month spelled
> out, so no one accidentally thinks it's the American format :-)
>
> Craig