Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119028 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 59105 invoked from network); 24 Nov 2022 16:05:33 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Nov 2022 16:05:33 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id B8F681804BE for ; Thu, 24 Nov 2022 08:05:31 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS8560 212.227.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 24 Nov 2022 08:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1669305926; bh=CceSNK3H+NeasXfRcnPcEbTjBH8QfY6XzUCfnfOF+28=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=dPThe8v1gzJhcjj4AitWHGju2w8gkefYvzkx9FM6ABKhtGE8BfDnD8x1rC1CUvD0K 2yL4xAFwyegwItHZBfDaQVe+xKduU8x8zBmKO2Kzjt/h5wAIfOTgxO5kC/B/R1Ojhr QZ2BMRU2Q9ddrjiODi+KT2+5OJdEfPr46CH0DCavzutGAIgeA4MGYsVNfCaA1LnLAC LND9h2thC0w/7iMdBrIGNK21Ax3BdVCTQJu6z8BzT8PebFZATlkzxlPb5dYh+qpiOc 3fmo6WQ6jQ/ZnqvB0u8F0PQf+TVW1pbepzrwJUmCwtz60DcV4wKp1OEqlmnW3Y45EI Yhw63Ksfd2Upg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.2.130] ([79.220.80.221]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrQJ5-1pIBY92gH1-00oU06; Thu, 24 Nov 2022 17:05:26 +0100 Message-ID: <720f174d-a19f-59ac-e575-cc16214e9e04@gmx.de> Date: Thu, 24 Nov 2022 17:05:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: Thomas Hruska , PHP Development References: <5a5bf716-1c4a-aec8-f48f-5dc92166e1a2@cubiclesoft.com> In-Reply-To: <5a5bf716-1c4a-aec8-f48f-5dc92166e1a2@cubiclesoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pE1+XZDdGR9pGc7csI2Pc7CEPIkIeiVy+EjVpOM4xL9+9oGV7P3 00SKoowb6qSUp/8xhRbnqQ7K8i0eZYEAZu9vbnGR5t5bStSjBC3wstFIb9hAAJ1SOGAum9+ OKqwC+EINxhuBJxpcsSsRDIyaQIgEuZ3dKQjdKWhJuY6JmMqcZZP6BzaHD6zF2+rEGXrf1n 8DoOY3v6kld7F9x+MubSw== UI-OutboundReport: notjunk:1;M01:P0:GT7FpgaEM1E=;qmD/R37tRjezZfXefJ/MEH7KUOl YeR6XWLEkQ0+xoFI5LGQPSKU7Ws2P24Mbap766ttn6jORmt+C0k1QNHDuHyKTzp7LCwl3m7FE Mv0FAIK8tIZWY+QjaK7hqnPzUU4XPBMQsP8YHTNa+ut6aSnxr8zGO5SNfDN5ZX3iJb+5hmZCE sT0q6qJObqm1mYYVn0tYpK84BJYJoSN8vue9IISJJW8APkULDecrC9Fv00q8CZgvSBWoJBtI+ sQ8wh7z+MrwkNEtZfhJcl/C33dMwXpqKN5HBQ7fg/aJ/e+QUEqykobMST8qQ5H3EbbjxY7sed tP3wiJ9uRg+AdJsMz4kV98Dwfk/6ntbEYF4GPHJXeQLA3SeCkh9XpLpPDtMICdtMgj3dN+LZI QM/hIrJnJLoRPqXVWP5xJjaKHozs3olTfME92MkPsvsT8o+B7Do75kkbP+fFEm44LiU6FRktV lsZh59uMxpfb2MqOQ6MtAdCYs+hajDsqUtyloGnYJ/BKNpD1089onvDSN/Oq0rZuZ6iuUxk0k jfjK9AhkGCJHNF4msApC7DrlzKpc3hfyurWtGA4vjJOtXmFpFtrHyIj1uHf/AW0vfRzdAmMq4 VBQkPyPG1d/4XgAGkFDVyDsJEtsJfnypuN16D6bomk6UWmCEkD9SnxiWPUA0nzAZAy+0gybLT BZ3nCLPTBdFtDBUNwapVecTf0Y5FZRhLAfXVq3iaXxVKW5eE56LjEwClC69XmaOzCUgNw1rBf 6G003ISQqM8JWNDYSqR3bfRl8ecb5AXr4iHf5kpdeTx5/9bCxXwVxDGRzAcJ2Bfna34MlQ9XE wUFY5OnEON5ElM3cFOZc40InVtJGWppyn9YZzuLgKk2JtfJKh6TR+1sMogW3xV2dkUYRW86+5 N289dxnOaL9ifxrT5+78+2M/WMut6fpBfOXEcfvRdj2Nk/7ybIZ9YWr0IhmBPwfFHbx1nohjn B25qGg== Subject: Re: PHP_STREAM_TO_ZVAL From: cmbecker69@gmx.de ("Christoph M. Becker") On 24.11.2022 at 16:35, Thomas Hruska wrote: > In ext/standard/file.c: > > #define PHP_STREAM_TO_ZVAL(stream, arg) \ > =C2=A0=C2=A0=C2=A0=C2=A0ZEND_ASSERT(Z_TYPE_P(arg) =3D=3D IS_RESOURCE); \ > =C2=A0=C2=A0=C2=A0=C2=A0php_stream_from_res(stream, Z_RES_P(arg)); > > Can someone clarify why that macro is named PHP_STREAM_TO_ZVAL?=C2=A0 Th= e > current name seems to imply the inverse of what actually happens. Yeah, looks like the commit which introduced that macro[1] got it wrong, and nobody noticed or changed that later. Maybe you want to provide a PR which fixes this. [1] =2D- Christoph M. Becker