Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119020
Date: Mon, 21 Nov 2022 12:36:01 +0000
To: internals@lists.php.net, Vincent Langlet <mr.vincent.langlet@gmail.com>,
 PHP Internals List <internals@lists.php.net>
User-Agent: K-9 Mail for Android
In-Reply-To: <CABEW5qdmre4qTzfDsaQN1q8NCTgEXvf+3=jY1yOjeLx2vzBTTw@mail.gmail.com>
References: <CABEW5qdmre4qTzfDsaQN1q8NCTgEXvf+3=jY1yOjeLx2vzBTTw@mail.gmail.com>
Message-ID: <707E8C39-F471-4C6F-B59C-A0D60D4C663E@php.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Using less generic exceptions for dates
From: derick@php.net (Derick Rethans)

On 21 November 2022 11:34:10 GMT, Vincent Langlet <mr=2Evincent=2Elanglet@g=
mail=2Ecom> wrote:
>Hi,
>
>When using json_encode or json_decode with the `JSON_THROW_ON_ERROR` flag=
,
>`JsonException` might be thrown=2E
>
>When using `new DateTime('foo')`, a generic `Exception` is thrown=2E
>Incidentally, I wonder why it's not an `InvalidArgumentException` (but th=
at
>could be another debate)=2E
>
>But my main point is that I think it would be useful to use a specific
>exception
>```
>class DateException extends Exception {}
>```
>- It allows a specific treatment when catching exceptions
>- It allows a specific analysis when using static analysis tools like Psa=
lm
>or PHPStan=2E
>
>In a general way, I would say that PHP class/method should always use
>scoped Exception instead of generics ones=2E
>
>I know nothing about how php is implemented but I would say introducing
>DateException shouldn't be too hard and it's BC=2E What do you think ?

I think this is a good idea and will add it to my todo list to investigate=
=2E

cheers
Derick