Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119019
MIME-Version: 1.0
Date: Mon, 21 Nov 2022 12:34:10 +0100
Message-ID: <CABEW5qdmre4qTzfDsaQN1q8NCTgEXvf+3=jY1yOjeLx2vzBTTw@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c2f8b205edf96f8b"
Subject: Using less generic exceptions for dates
From: mr.vincent.langlet@gmail.com (Vincent Langlet)

--000000000000c2f8b205edf96f8b
Content-Type: text/plain; charset="UTF-8"

Hi,

When using json_encode or json_decode with the `JSON_THROW_ON_ERROR` flag,
`JsonException` might be thrown.

When using `new DateTime('foo')`, a generic `Exception` is thrown.
Incidentally, I wonder why it's not an `InvalidArgumentException` (but that
could be another debate).

But my main point is that I think it would be useful to use a specific
exception
```
class DateException extends Exception {}
```
- It allows a specific treatment when catching exceptions
- It allows a specific analysis when using static analysis tools like Psalm
or PHPStan.

In a general way, I would say that PHP class/method should always use
scoped Exception instead of generics ones.

I know nothing about how php is implemented but I would say introducing
DateException shouldn't be too hard and it's BC. What do you think ?

--000000000000c2f8b205edf96f8b--