Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119000
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
In-Reply-To: <0854b030-c51c-4c1b-a7dd-22835a1e5da9@app.fastmail.com>
Date: Mon, 14 Nov 2022 08:04:24 +0100
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <9AB678BC-ACF1-47F0-92A2-6F47AA1CEDBE@gmail.com>
References: <0854b030-c51c-4c1b-a7dd-22835a1e5da9@app.fastmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, with readonly
From: claude.pache@gmail.com (Claude Pache)



>=20
> public public(set) readonly string $foo
>=20
> protected protected(set) readonly string $foo
>=20
> These would be the only way to have a non-private-set readonly =
property.  While the first is in practice quite unlikely, the second has =
valid use cases. =20

Both have use cases. Whether they are valid is quite subjective. (I am =
speaking as someone who suffer from the `match()` construct forbidding =
having both `default` and  some other `case` pointing to the same =
expression. That restriction seemed reasonable the time the feature was =
designed and voted.)

>=20
> 1. Relax the set-is-tighter restriction.  That would allow `protected =
protected(set)` etc. on any property.  It wouldn't be particularly =
useful unless readonly is being used, but it would be syntactically =
legal and behave as you'd expect.  We could still disallow "set is more =
permissive" combinations (eg, `private public(set)`), as those have no =
apparent use case.

I think that Option 1 is the most reasonable. The meaning of `public =
public(set)` and `protected protected(set)` is straightforward; from a =
user point-of-view, disallowing them seems more like =E2=80=9Cit is =
useless=E2=80=9D than =E2=80=9Cit is confusing=E2=80=9D. Unless there =
are good technical reason to restrict it, we can just leave to linting =
tools the care of reporting it.

=E2=80=94Claude