Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118973
MIME-Version: 1.0
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de> <CABTDVhBRStgOZAmthdEf9tRPLff6EbucL+kn0sXY8KQMMqjH1Q@mail.gmail.com>
In-Reply-To: <CABTDVhBRStgOZAmthdEf9tRPLff6EbucL+kn0sXY8KQMMqjH1Q@mail.gmail.com>
Date: Sun, 6 Nov 2022 00:43:02 +0900
Message-ID: <CABTDVhAWJ1ZHTre0z4Cj-KPApLQYQkWu1G7b80g1yZQ1g909Lg@mail.gmail.com>
To: =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000051b0a705ecbb0ce1"
Subject: Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions
From: zeriyoshi@gmail.com (Go Kudo)

--00000000000051b0a705ecbb0ce1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B411=E6=9C=886=E6=97=A5(=E6=97=A5) 0:34 Go Kudo <zeriyoshi@gmail=
.com>:

> 2022=E5=B9=B410=E6=9C=8814=E6=97=A5(=E9=87=91) 4:38 Joshua R=C3=BCsweg vi=
a internals <internals@lists.php.net>:
>
>> Hi
>>
>> Tim D=C3=BCsterhus and I have created an RFC to add new methods that sol=
ve
>> commonly encountered use cases to \Random\Randomizer. Specifically
>> creating a random string consisting of specific bytes and generating
>> random floating point values.
>>
>> You can find the RFC at:
>>
>> https://wiki.php.net/rfc/randomizer_additions
>>
>> Proof of concept implementation is in:
>>
>> * https://github.com/php/php-src/pull/9664
>> * https://github.com/php/php-src/pull/9679
>>
>> ----
>>
>> Some open questions to start the discussion:
>>
>> * Are you missing other commonly useful operations that are also useful
>> to have in core?
>> * Do you agree with the method names? Within the PR we received comments
>> that "alphabet" might not be an appropriate term.
>> * Shall an option be added to getFloat() that changes the logic to
>> select from [$min, $max] (i.e. allowing the maximum to be returned)? And
>> how should that look like? Boolean parameter? Enum?
>>
>> ----
>>
>> We're looking forward to your feedback.
>>
>> Cheers
>>
>> Joshua R=C3=BCsweg
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php
>>
>>
> (I made a mistake in replying to your message, so I will reply again here=
.)
>
> Hi
>
> I have read the RFC. I think the content is generally good and adequately
> compensates for the areas that could not be completed.
>
> I am skeptical only about getFloat(). The use cases are limited and seem
> somewhat excessive. Do you have examples of how this is supported in othe=
r
> languages?
>
> Regards
> Go Kudo
>

Sorry, I did not read the updated RFC. The latitude and longitude samples
were very clear and even my limited understanding of floating point numbers
helped me understand why they were necessary.

I am so far in favor of this RFC and positive about both features. I also
agree that as a member of the maintainer I will maintain it properly.

Thank you for your very coherent writing and implementation.

Best Regards
Go Kudo

--00000000000051b0a705ecbb0ce1--