Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118965
Message-ID: <e8cbc04a-71fc-0e93-aa8e-63192982d897@gmx.de>
Date: Fri, 4 Nov 2022 15:55:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
To: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
References: <CAPyj-LCy-fiXuVSDb8tM+Nifv+9xk=1KGDvk-_aHdkQu7j7ADA@mail.gmail.com>
 <CABAhh3HXnkwunskSgpH95iouM2Xui6LMx=zgLwq1_MsTyh9T1Q@mail.gmail.com>
 <0053C284-958F-482E-A648-39652442D4B8@gmail.com>
In-Reply-To: <0053C284-958F-482E-A648-39652442D4B8@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:q+AnxQEOG1s=;QouXKkY8qVvviQoMLNC8BG/1xPD
 b0+VqJ5slaqQ1ZHaNufg/4ALKDnbcqTnxLV1FqVKdBtyhLt6qZZH3vuYm5AnROuznpVmAQpJH
 ftG5hHoz249jf59wYXCD4spXjfwVYUZeKr2UXddk8ThcNkfP2oZ+mZfpBLzGwmh+gnfRDQmZS
 M2ZrU1JMCwNx+b3oOrO0KCgme4AVBD74pzcPU5klfiTNPHuzFz+wLy6YqCSrqFwbLsZRTqXeX
 CWGoXo1FNx/sTvk99Qk+5tl8w2EHRVQVTmvcUpxsZs2Dk6KnAwI7W+YcJHOoBrEcUh3hh115V
 bQg1Fn4LWq3CFufuXiJ91qp++aiGxLisIDnPB7Y5XIZVE/LNyM+Qv99o+iHDuORLGAkJWAUA+
 Wy0gRsBYMZ2RZjbAFlnLjqVq9G1Y/jGQqZb9Nwk/0wabfkFx0isK/OEd+en4/gWe+3bSUjg2o
 +G03qruKbQBvA8gbZd91YTE8u8jn5bFiQ+cLs923juzbw8S9ZaF45JcodslZWlkED+3Qb6HVb
 hx7uJxlySp9CXam1H2Bv0rq3dt+HT4qHALIE7/3Dy4CNcPI9W0uoAt+g+gf7SH/VJ7hefgAdc
 VcLIBBgzboGihA2iK2fpdugwGPBvpGBvT37pEfHSLh2Dr0WPaJ9PjZEY9cUvVjbSaGaZ0/nt4
 kYSZ6vS+mrauu3tHSSK8k4YEpbEnVchdq6OcEO5wHLN5mU0wqChstdBAsZeuQB6IHk/sUUtDY
 2vyfSN54u9XXaIg6rgmC6KszSkX/euWqzF2n5H5bg7hGA7wSakNpCe+YHtil3qNyeu2LaVXkG
 ud5wdNPANN+lqkh7NhwhD2cnUoGcjlULmTvYTVFjYxMGUB0UTCUFeKQ8P5wXUWbUoWTfBEM4U
 rDmVHQGHx9X9JgPs3jO5Kri7e9HHgbzeN2N9PRqDpmWrl3MJAQw5s4X0dujuO+3tC7ZdCuEND
 k+1Q7Q==
Subject: Re: [PHP-DEV] ARRAY_UNIQUE_IDENTICAL option
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 04.11.2022 at 10:05, Rowan Tommins wrote:

> On 3 November 2022 18:53:40 GMT, someniatko <someniatko@gmail.com> wrote=
:
>
>> You will have to memorize yet another PHP quirk, or be able to build a
>> logical chain:
>> - enums are non-comparable by default
>> - enums have no default string value (if not baked by a string)
>> - array_unique internally sorts an array
>> - default flag for array_unique compares the string representations of =
its items
>> - thus it won't work for enums in a general case
>
> Actually, I think this is already the case for "normal" objects - I had =
no idea that array_unique used a string cast to compare objects, so am ver=
y surprised that it will not consider objects of completely different clas=
ses unique, if they happen to have the same string value: https://3v4l.org=
/UGCvB
>
> Making backed enums work with their backing value would be equally confu=
sing to me - Day::MONDAY and Month::JANUARY might both be backed by a 1, b=
ut they are certainly distinct values. I'd much rather get an error that m=
ade me check the manual and find a flag than have one of them silently dis=
carded.

I agree.  In my opinion, we should *consider* to *always* raise a
warning on attempts to compare incomparable values.  As it is now,
silently returning false looks like a footgun to me.

=2D-
Christoph M. Becker