Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118958
MIME-Version: 1.0
References: <21C5073D-3F39-49DA-8686-E027AE780793@joshbruce.dev>
 <D14A346D-6234-4A85-9266-4125236B3F3E@joshbruce.dev> <1bc7759a-63b8-4b96-bb69-97b50f851307@www.fastmail.com>
 <E6C6FE8B-C263-46AB-B851-14DEB4AED52A@joshbruce.dev> <DM6PR07MB66189EA71A5EBDFD16CEDC05F9470@DM6PR07MB6618.namprd07.prod.outlook.com>
 <C3C433DA-B9C0-4B49-98C7-9D163AF713F9@joshbruce.dev> <94DC0839-E43B-4F3A-9105-8F3CB9D7BBC1@joshbruce.dev>
 <B061594C-7516-412E-AEAA-61BE25938377@joshbruce.dev> <CABdc3WrDAE0Af+kY+6myAzJDJcLpNyU8ebODxbs2tXF3w9GNQg@mail.gmail.com>
 <9AE33306-ED89-4FE4-86A5-89B4EDC81545@gmail.com> <CADyq6sK+MEsG=U58XnkEyRRyw_a0Zt=wxUr4UWRM9JDG_wCfnA@mail.gmail.com>
 <13A9249B-C3B2-46E3-AB50-D46FAA2A301E@joshbruce.dev> <C406C2F8-02AE-4495-A067-A6BC9DE9ED49@gmail.com>
 <F6F7D548-8499-480F-8B18-0ABD0EAA5276@joshbruce.dev>
In-Reply-To: <F6F7D548-8499-480F-8B18-0ABD0EAA5276@joshbruce.dev>
Date: Fri, 4 Nov 2022 06:37:40 +0100
Message-ID: <CABdc3WqePKe8Br1d_qEA9f=PK5L46tRi3ANXzxDd3UmiU8b3Zg@mail.gmail.com>
To: Josh Bruce <josh@joshbruce.dev>
Cc: Claude Pache <claude.pache@gmail.com>, Marco Pivetta <ocramius@gmail.com>, 
	php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008f52d305ec9e7946"
Subject: Re: [PHP-DEV] [RFC][Discussion] Objects can be declared falsifiable
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--0000000000008f52d305ec9e7946
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
> if ($response->getStatusCode() > 199 and $response->getStatusCode() < 300=
)
> {
>   // do something with =E2=80=9Ctrue=E2=80=9D - which has a range of 100 =
possibilities at
> a granular level, which we could respond to differently - possible to
> interact with $response
>
> }
> // do something with =E2=80=9Cfalse=E2=80=9D - which has a range of more =
than 100
> possibilities at a granular level, which we could respond to differently =
-
> possible to interact with $response
>
> We might wrap response to create an isOk() method to move the conditional
> logic somewhere within the object itself and make the call site more
> readable.
>
> If ($response->isOk()) {
>   // do something with =E2=80=9Ctrue=E2=80=9D - still able to interact wi=
th $response
>
> }
> // do something with =E2=80=9Cfalse=E2=80=9D - still able to interact wit=
h $response
>

This looks way much cleaner and is easy to read and understand.
While I understand the proposed feature is opt-int it introduces more magic
that can be solved using more verbose and IMO cleaner solutions.


> With the RFC:
>
> if (new MyType($config)) {
>   // do something with =E2=80=9Ctrue=E2=80=9D - can=E2=80=99t use MyType =
because not assigned
>
> }
> // reachable because possible to resolve to false - if implements
> Falsifiable and __toBool can resolve to false - can=E2=80=99t use MyType =
because
> not assigned
>
> if ($response =3D new MyType($config)) {
>   // do something with =E2=80=9Ctrue=E2=80=9D - with the option of using =
$response
>
> }
> // reachable - can=E2=80=99t use MyType because may not be assigned
>
> $response =3D new MyType($config);
> If ($response) {
>   // do something with =E2=80=9Ctrue=E2=80=9D - with the option of using =
$response
>
> }
> // do something with =E2=80=9Cfalse=E2=80=9D - with the option of using $=
response
>

This is somehow confusing, why is the $response storing object ref is ok
while inclining the new object creation is not?
This requires more attention while reading and debugging.

Cheers,
Micha=C5=82 Marcin Brzuchalski

--0000000000008f52d305ec9e7946--