Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118928
Message-ID: <381a2aa6-a479-1791-2d5b-9aac19004fd1@bastelstu.be>
Date: Mon, 31 Oct 2022 18:53:12 +0100
MIME-Version: 1.0
Content-Language: en-US
To: Jordan LeDoux <jordan.ledoux@gmail.com>, =?UTF-8?Q?Joshua_R=c3=bcsweg?=
 <josh@wcflabs.de>
Cc: internals@lists.php.net
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de>
 <02f9fc3b-2972-dfdb-9d76-df120efc73b3@wcflabs.de>
 <CAMrTa2EQFzOW8eWbF7w=dKkaxUWZYVE0AMvtpRXmiRO0fM1irw@mail.gmail.com>
In-Reply-To: <CAMrTa2EQFzOW8eWbF7w=dKkaxUWZYVE0AMvtpRXmiRO0fM1irw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: RFC [Discussion]: Randomizer Additions
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 10/29/22 00:44, Jordan LeDoux wrote:
> I had a discussion with Tim about this naming topic as well, and want to
> convey my suggestion along with the reasoning.
> 
> I think the enum should be `Random\IntervalBoundary` with the enum cases:

Yes, I agree this is a much better name for the enum itself and just 
adjusted the implementation and RFC.

> `IntervalBoundary::Open`
> `IntervalBoundary::Closed`
> `IntervalBoundary::OpenRight` or `IntervalBoundary::HalfOpenRight`
> `IntervalBoundary::OpenLeft`  or `IntervalBoundary::HalfOpenLeft`
> 

But for the enum members I prefer the existing naming of 
(Closed|Open)(Closed|Open), unless someone has a good argument for a 
different naming scheme:

- It's very explicit, which I consider useful for two reasons which are 
likely related:

(a) I don't have to think about what "OpenRight" means for the left 
boundary.
(b) As not-a-native-speaker-of English I find OpenRight or HalfOpenRight 
not completely obvious and would likely need to look up what exactly 
OpenRight means, whereas ClosedOpen is understandable more intuitively. 
Especially since a half-open interval is sometimes referred to as 
half-open and sometimes as half-closed. The preferred variant might even 
differ across languages.

- It's nicely symmetric from the naming.

- It's the naming used by Prof. Goualard in the Drawing Random 
Floating-Point Numbers from an Interval paper (though in a shortened CC, 
CO, OC, OO variant).

Best regards
Tim Düsterhus