Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118918
MIME-Version: 1.0
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de> <CAAwdEzCVokPfcavL6ygrQqXmfBEcaSG-tYOnkXhTMJmj7j8q1g@mail.gmail.com>
In-Reply-To: <CAAwdEzCVokPfcavL6ygrQqXmfBEcaSG-tYOnkXhTMJmj7j8q1g@mail.gmail.com>
Date: Sun, 30 Oct 2022 21:44:53 +0900
Message-ID: <CABTDVhDhBHZC5gk07+kWcQjCoMmcjcgw-jRLJmNE=ZbOjHtH2g@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000398a4105ec3fdc0b"
Subject: Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions
From: zeriyoshi@gmail.com (Go Kudo)

--000000000000398a4105ec3fdc0b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B410=E6=9C=8814=E6=97=A5(=E9=87=91) 13:33 Alexandru P=C4=83tr=C4=
=83nescu <drealecs@gmail.com>:

> On Thu, Oct 13, 2022, 22:37 Joshua R=C3=BCsweg via internals <
> internals@lists.php.net> wrote:
>
> > Hi
> >
> > Tim D=C3=BCsterhus and I have created an RFC to add new methods that so=
lve
> > commonly encountered use cases to \Random\Randomizer. Specifically
> > creating a random string consisting of specific bytes and generating
> > random floating point values.
> >
> > You can find the RFC at:
> >
> > https://wiki.php.net/rfc/randomizer_additions
> >
> > Proof of concept implementation is in:
> >
> > * https://github.com/php/php-src/pull/9664
> > * https://github.com/php/php-src/pull/9679
> >
> >
> >
> > Some open questions to start the discussion:
> >
> > * Are you missing other commonly useful operations that are also useful
> > to have in core?
> >
>
> For completeness, it would be good to have nextBool() as well.
>
> * Do you agree with the method names? Within the PR we received comments
> > that "alphabet" might not be an appropriate term.
> >
>
> Yes, alphabet is fine by me but I can suggest also: character set,
> character list, character dictionary, byte set, byte list, byte dictionar=
y
> or some shortcuts of it, like charset.
>
> * Shall an option be added to getFloat() that changes the logic to
> > select from [$min, $max] (i.e. allowing the maximum to be returned)? An=
d
> > how should that look like? Boolean parameter? Enum?
> >
>
> No, IMO. Mathematically it doesn't really make sense and talking about
> floats, it will also be a very corner case not reached in tests that migh=
t
> happen in production rarely and break things.
>
>
> > ----
> >
> > We're looking forward to your feedback.
> >
> >
> > Cheers
> >
> > Joshua R=C3=BCsweg
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php
> >
>
> >
> >
> I am having another small issue.
> As the Randomizer class is final, I guess this will not be perfectly
> polyfillable in userland.
> So... , if accepted, would it be completely wrong to have these new metho=
ds
> in PHP 8.2? What can it break?
>

> As the Randomizer class is final, I guess this will not be perfectly
polyfillable in userland.

What case do you envision for this? Probably, most cases can be polyfilled
by code: https://3v4l.org/JludD

And it seems that someone has already done such an implementation (which is
very nice and I would like to express my utmost appreciation).

https://github.com/arokettu/php-random-polyfill

Regards
Go Kudo

--000000000000398a4105ec3fdc0b--