Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118909
MIME-Version: 1.0
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de>
 <CA+kxMuQECpLyt_D63jzBB1T4K57eVCCHD7JToA==bbHojkhb9w@mail.gmail.com>
 <a0ee88b7-8fc6-ad67-4aec-811beebdc58a@bastelstu.be> <71552420-ae73-4404-b149-49e73ec29d20@app.fastmail.com>
 <ba30547e-3a85-f3e7-2f3d-3dec5dde0833@wcflabs.de>
In-Reply-To: <ba30547e-3a85-f3e7-2f3d-3dec5dde0833@wcflabs.de>
Date: Fri, 28 Oct 2022 14:43:28 -0700
Message-ID: <CAMrTa2HOf3yPwry+Y6=R7gLztQ6oho4ab-J7nm24yfgzxv=kpA@mail.gmail.com>
To: =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>, Larry Garfield <larry@garfieldtech.com>
Content-Type: multipart/alternative; boundary="000000000000a63eb805ec1f26c8"
Subject: Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions
From: jordan.ledoux@gmail.com (Jordan LeDoux)

--000000000000a63eb805ec1f26c8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2022 at 12:30 PM Joshua R=C3=BCsweg via internals <
internals@lists.php.net> wrote:

> Hello!
>
> [As Larry kindly pointed out to me, I only sent the email to Larry and
> not to the mailing list.]
>
> > "Alphabet" here still, to me, implies a character set, not a byte
> stream.  Maybe getBytesFromString?  getBytesFromList?  getBytesFrom()
> (because you're getting it "from" the string that's provided, so you don'=
t
> need another noun there.)?
> >
> > I'm not opposed to the functionality, but "alphabet" doesn't seem like
> the right word for it.
>
> I'm not really happy with the name either and was hoping for some
> suggestions. `getBytesFrom` sounds incomplete to me. `getBytesFromList`
> sounds to me as if an array is being passed there and not a string.
> `getBytesFromString` sounds good to me, though. Better than
> `getBytesfromAlphabet`!
>
> Cheers
>
> Joshua R=C3=BCsweg
>

Not to try and bikeshed further, but wouldn't `getBytesFromChars` or
`getBytesFromCharList` be more clear while being nearly as accurate?

Jordan

--000000000000a63eb805ec1f26c8--