Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118906
MIME-Version: 1.0
References: <DM6PR14MB4155BEF0A6C924DB3812C97DF9329@DM6PR14MB4155.namprd14.prod.outlook.com>
 <CAAKU0umca3aY+Ha31Vr9h0ZHMYBqO9aetsS8x0KJo8iXKPsZyA@mail.gmail.com>
In-Reply-To: <CAAKU0umca3aY+Ha31Vr9h0ZHMYBqO9aetsS8x0KJo8iXKPsZyA@mail.gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Fri, 28 Oct 2022 11:45:31 -0600
Message-ID: <CAAKU0um-Wougq4KNx=ZAC=c30jzMqC3NMBpHUV04Fr7WTMc5Qg@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Proposal: Expanded iterable helper functions and
 aliasing iterator_to_array in `iterable\` namespace
From: internals@lists.php.net ("Levi Morrison via internals")

> > There's other functionality that I was less certain about proposing, such as `iterable\keys(iterable $iterable): array`,
> > which would work similarly to array_keys but also work on Traversables (e.g. to be used with userland/internal collections, generators, etc.)
>
> I assume this doesn't care about key uniqueness -- it takes the keys
> and makes them values, in the same order they were returned?
>
> In any case, I don't think this should return an iterable, not array,
> to allow for lazy operations in a chain, while also allowing for using
> an array as an optimization.

Oops, I meant to say I think this should return an iterable, not an array.