Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118904
Message-ID: <a7a3371f-b89a-abc4-d8a4-673d1c215ce0@bastelstu.be>
Date: Fri, 28 Oct 2022 19:37:50 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Pedro Nacht <pnacht@google.com>
Cc: Jordan LeDoux <jordan.ledoux@gmail.com>, internals@lists.php.net
References: <CAFWHjfpriiBX1Xg34F95zXsgwKQeh1-AwActDws5wuRL83pHhQ@mail.gmail.com>
 <CAMrTa2E5VHJGANm0u3Nrs9a9DeoJspE7JAg0902TzDi1Pq4iiA@mail.gmail.com>
 <CAFWHjfr0gFxzqRX12N7u5pWfNkafDeW8Y81d8E==5ibg2_=MiQ@mail.gmail.com>
 <19932b6e-efe8-d24a-0e1e-e8960fb1566b@bastelstu.be>
 <CAFWHjfoWOQxQ1rCWApRsvDV0SUKq8CWx0J=nbuFmZQ83=hcxzQ@mail.gmail.com>
In-Reply-To: <CAFWHjfoWOQxQ1rCWApRsvDV0SUKq8CWx0J=nbuFmZQ83=hcxzQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Adding the OpenSSF Scorecards GitHub Action
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

as a heads up: Please do not top post (as per 
https://github.com/php/php-src/blob/master/docs/mailinglist-rules.md). 
Your previous replies were already correct.

On 10/28/22 19:11, Pedro Nacht via internals wrote:
> And if there's interest, I'll happily fix that small inconsistency in the
> labeler.yml permissions.

I obviously can't speak for the others, but I am interested for as I 
said in my first reply. Consistency is good, if it makes some automated 
scanner happy to prevent users from asking about the results in the 
future, even better. So yes, please send a PR. I'd also say: Feel free 
to also send PRs for other stuff in the future. A PR that actually 
*fixes* some obvious issue or improves something without a drawback 
should generally be well-received. In fact that's how the action 
permissions config was introduced in the first place - by an non-core 
contributor:

https://github.com/php/php-src/pull/9440

Best regards
Tim Düsterhus