Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118897
Message-ID: <beeb95cb-5f93-bbf2-50a4-1447589c5f68@bastelstu.be>
Date: Fri, 28 Oct 2022 16:01:35 +0200
MIME-Version: 1.0
Content-Language: en-US
To: PHP internals <internals@lists.php.net>
References: <22177032-fe72-c39b-63fe-fa4368a70852@bastelstu.be>
In-Reply-To: <22177032-fe72-c39b-63fe-fa4368a70852@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [VOTE] Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 10/14/22 15:44, Tim Düsterhus wrote:
> Voting will run 2 weeks until:
> 
> 2022-10-28 at 14:00 UTC
> 

Voting just closed. The RFC was partly accepted:

a) "Add the \UnserializationFailedException and wrap any Throwables in 
PHP 8.x?"

This proposal was declined with 20 (Yes) to 12 (No) Votes (62.5%).

b) "Increase the severity of emitted E_NOTICE to E_WARNING in PHP 8.x?"

This proposal was accepted with 33 (Yes) to 2 (No) Votes (94.3%).

c) "Throw \UnserializationFailedException instead of emitting 
E_NOTICE/E_WARNING in PHP 9.0?"

This proposal depends on declined proposal (a) and thus results will be 
disregarded. It would have been accepted with 23 (Yes) to 8 (No) Votes 
(74.2%).

-----------------

The implementation for the accepted proposal (b) is already completed 
and waiting for review at: https://github.com/php/php-src/pull/9629.

Best regards
Tim Düsterhus