Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118878 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 91529 invoked from network); 24 Oct 2022 15:53:11 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Oct 2022 15:53:11 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id AC5AC180505 for ; Mon, 24 Oct 2022 08:53:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS19151 66.111.4.0/24 X-Spam-Virus: No X-Envelope-From: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 24 Oct 2022 08:53:10 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B3B95C016D for ; Mon, 24 Oct 2022 11:53:09 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute1.internal (MEProxy); Mon, 24 Oct 2022 11:53:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= garfieldtech.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666626789; x= 1666713189; bh=xGFfZhkzz3aUXdumS/IiQAMjxBvtjCCUe/UaPkbJJPQ=; b=M S/Z5AzUkuY8l+QY+CRwXPWgf8jtUKPT7H44Spk0K2sqHI+hOWOlBu3UfkzTubwjn nMbPJkh9VH87ltNkXqB4EUAt8wDCcPUwRwcwJV6QaGQfAyuSd/HTsq/dijK/gUcg OGVOdLqCQ9dzjYBiZz7C76otVtKgZMNKAx8HDu4zK1vsJMjM+/tHdeAs5P52D0BR ouZTpdAe9TkXepYF82mkE+eYpJmD2hvAXX84uHMW672qMREzZxT8Cq28HtE5UWns 4Ad+QDojizADtGWdc5OgbfOBVn/J8Zo4/VZLrFijN0mRh/lVepIbUgYXLLUenF/U uiyth65aVvt4TYkz4hTKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666626789; x=1666713189; bh=xGFfZhkzz3aUXdumS/IiQAMjxBvt jCCUe/UaPkbJJPQ=; b=mSK3aeRZourNH6e0zhoK7cfgiLNxw3GXcMtK5OXjTv7T J/OgObGICbHODcLGQmjAC4LiljIjau9QX0/nmUWXeVazwSIPn9I22aZJ66ivKcdn XNxICB65aeeV2mGLkfWlirQxGPdJa7yQB4KX8pJ9Txz/4XSn3UdDEOBO3eAeQR+F 3UImgZCtinBkGUO9CBEfFGUuKI71eHXpO7rZsjLQiLtSjuzyaZNBvaMkYSRE1RLq 70OIh3qirDXGR/V2py308OwMti4sqtvRHxUOd5cX2TQ1V2PgnBr6RhwcBAwSb26f Mk0rJTPepgyw1Me7Cc7puYUBXtgqz0RMon2g3rzz7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtgedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfnrghr rhihucfirghrfhhivghlugdfuceolhgrrhhrhiesghgrrhhfihgvlhguthgvtghhrdgtoh hmqeenucggtffrrghtthgvrhhnpeevheehvdevjeelvdevgfelvefftdejkeelvdekgeeh fffgiedvjefhhfeltdduteenucffohhmrghinhepphhhphdrnhgvthenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlrghrrhihsehgrghrfhhi vghlughtvggthhdrtghomh X-ME-Proxy: Feedback-ID: i8414410d:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 47E5F1700083; Mon, 24 Oct 2022 11:53:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-ID: In-Reply-To: <20221024045645.00bfc0d2@platypus> References: <20221024045645.00bfc0d2@platypus> Date: Mon, 24 Oct 2022 10:52:48 -0500 To: "php internals" Content-Type: text/plain Subject: Re: [PHP-DEV] [RFC] [Discussion] SQLite3: remove warnings, move to exceptions From: larry@garfieldtech.com ("Larry Garfield") On Sun, Oct 23, 2022, at 9:56 PM, BohwaZ wrote: > Kia ora, > > I am proposing that the SQLite3 extension stops using warnings for > errors and instead throws exceptions by default: > > https://wiki.php.net/rfc/sqlite3_exceptions > > Whether we just deprecate warnings first and default to exceptions, and > then remove warnings altogether in a later version, or just disable > warnings directly, is probably the important part of the RFC. > > My personal point of view is that modern code probably already have > enabled exceptions in the class, or is transforming warnings into > exceptions using an error handler. > > If not, it's relatively easy to set a exception handler to dismiss the > new exceptions if you don't want to see them. > > So going throught depreciation might not be necessary, but it's open > for discussion. > > Feedback is welcome :) > > Thanks. As others have said, the correct, responsible way to do this would be to make it gradual and keep warnings working until 9.0. I would recommend: 1. 8.3, enableExceptions(false) raises E_DEPRECATED. 2. 9.0 enableExceptions() defaults to true, and calling it with false is an Error. (Calling it with true still works, but is a no-op.) 3. 10.0 Remove enableExceptions() entirely. The behavior then only changes on major versions. I think we already did this for PDO, didn't we? It makes sense to do it for SQLite, too. --Larry Garfield