Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118856
Message-ID: <CD7B2BC2-BF8C-461B-9873-62C24B688952@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_31C87B34-5857-4587-AD32-9D7AAD681E61"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Date: Thu, 20 Oct 2022 09:15:01 +0200
In-Reply-To: <CABdc3WoroWF2MKJAyG1abyaiRpvh1E2Tn0BwnmB=cZoeGf+P7A@mail.gmail.com>
Cc: David Rodrigues <david.proweb@gmail.com>,
 Marco Pivetta <ocramius@gmail.com>,
 PHP Internals <internals@lists.php.net>
To: =?utf-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
References: <CAEsg9X1RnphjPQ++krRB-9nBmWTGJ6MGwQJyA=S0UxHzv7Bq-A@mail.gmail.com>
 <CADyq6sLrMaWk1JfA1U0QRBv_FzJVPy4UZAd+XyzJ4vGM3msWGQ@mail.gmail.com>
 <CAEsg9X3K868c9-sp8UtbNZi6A2OhBfnK=HnF95ZZwdW+5hwLqA@mail.gmail.com>
 <CABdc3WoroWF2MKJAyG1abyaiRpvh1E2Tn0BwnmB=cZoeGf+P7A@mail.gmail.com>
Subject: Re: [PHP-DEV] Compact can't resolve outer scoped variables using
 short closures
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_31C87B34-5857-4587-AD32-9D7AAD681E61
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


>=20
> How would you like it to work, if you pass a variable name variable to
> compact then?
> $x =3D 123;
> $name =3D 'x';
> (fn () =3D> compact($name))();
>=20

Although it is difficult to make it work in general (of course), there =
is the specific case of names given as literal strings, as in the =
example provided by the OP, that does not suffer from the impossibility =
of static analysis.


> I agree with the idea of deprecating compact() & extract() and in
> long-term variable of variables as well.

However, in `compact('x', 'y')`, the name of the variables are not =
variable, they are constant.

=E2=80=94Claude=

--Apple-Mail=_31C87B34-5857-4587-AD32-9D7AAD681E61--