Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118855
MIME-Version: 1.0
References: <CAEsg9X1RnphjPQ++krRB-9nBmWTGJ6MGwQJyA=S0UxHzv7Bq-A@mail.gmail.com>
 <CADyq6sLrMaWk1JfA1U0QRBv_FzJVPy4UZAd+XyzJ4vGM3msWGQ@mail.gmail.com> <CAEsg9X3K868c9-sp8UtbNZi6A2OhBfnK=HnF95ZZwdW+5hwLqA@mail.gmail.com>
In-Reply-To: <CAEsg9X3K868c9-sp8UtbNZi6A2OhBfnK=HnF95ZZwdW+5hwLqA@mail.gmail.com>
Date: Thu, 20 Oct 2022 08:31:06 +0200
Message-ID: <CABdc3WoroWF2MKJAyG1abyaiRpvh1E2Tn0BwnmB=cZoeGf+P7A@mail.gmail.com>
To: David Rodrigues <david.proweb@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000066eb605eb71790d"
Subject: Re: [PHP-DEV] Compact can't resolve outer scoped variables using
 short closures
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000066eb605eb71790d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=C5=9Br., 19 pa=C5=BA 2022 o 19:18 David Rodrigues <david.proweb@gmail.com>
napisa=C5=82(a):

> > I'd rather hope for `compact()` to finally be deprecated and targeted f=
or
> removal =F0=9F=98=9B
>
> I think compact() is a good function for transferring variables from one
> point to another, but I would think about making improvements as it is
> confusing (uses the variable name, rather than the variable itself).
>
> Regarding the bug, if we use an array it should work perfectly:
>
> $x =3D 123;
> (fn() =3D> [ 'x' =3D> $x ])();
>
> https://3v4l.org/ov7TM
>
> Would it be possible to automatically convert compact() to an array at
> runtime? So I imagine that any necessary optimization can take place
> directly over the resulting array, rather than the compact itself.
>

How would you like it to work, if you pass a variable name variable to
compact then?
$x =3D 123;
$name =3D 'x';
(fn () =3D> compact($name))();

I agree with the idea of deprecating compact() & extract() and in
long-term variable of variables as well.

Cheers,
Micha=C5=82 Marcin Brzuchalski

--000000000000066eb605eb71790d--