Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118851
MIME-Version: 1.0
References: <CAEsg9X1RnphjPQ++krRB-9nBmWTGJ6MGwQJyA=S0UxHzv7Bq-A@mail.gmail.com>
In-Reply-To: <CAEsg9X1RnphjPQ++krRB-9nBmWTGJ6MGwQJyA=S0UxHzv7Bq-A@mail.gmail.com>
Date: Wed, 19 Oct 2022 19:08:47 +0200
Message-ID: <CADyq6sLrMaWk1JfA1U0QRBv_FzJVPy4UZAd+XyzJ4vGM3msWGQ@mail.gmail.com>
To: David Rodrigues <david.proweb@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c7133705eb664317"
Subject: Re: [PHP-DEV] Compact can't resolve outer scoped variables using
 short closures
From: ocramius@gmail.com (Marco Pivetta)

--000000000000c7133705eb664317
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 19 Oct 2022, 19:04 David Rodrigues, <david.proweb@gmail.com> wrote:

> Hello!
>
> I'm converting my code to use short closures where possible, and I ran in=
to
> a problem using compact().
>
> Basically, the names used in compact() cannot be accessed due to a bug,
> reported in 2019 still in PHP 7.4 (ID 78970).
>
> https://bugs.php.net/bug.php?id=3D78970
>
> It seems to me to be a reasonable problem and one that needs attention, a=
s
> the message is not that "compact cannot be used here", but that "the
> variable does not exist".
>
> The code below may reproduce the problem:
>
> $x =3D 123;
> (fn() =3D> compact('x'))();
>
> https://3v4l.org/AFARs
>
> Is there any possibility of this being fixed? I would love to help, but I
> don't have much C programming skills, unfortunately.
>

I'd rather hope for `compact()` to finally be deprecated and targeted for
removal =F0=9F=98=9B

The fact that it still exists precludes (or at least complicates) future
optimization of scope + inlining in the engine.

Similar thoughts towards `extract()`, I'd say.

--000000000000c7133705eb664317--