Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118845
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad
Mime-Version: 1.0
Message-ID: <71552420-ae73-4404-b149-49e73ec29d20@app.fastmail.com>
In-Reply-To: <a0ee88b7-8fc6-ad67-4aec-811beebdc58a@bastelstu.be>
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de>
 <CA+kxMuQECpLyt_D63jzBB1T4K57eVCCHD7JToA==bbHojkhb9w@mail.gmail.com>
 <a0ee88b7-8fc6-ad67-4aec-811beebdc58a@bastelstu.be>
Date: Tue, 18 Oct 2022 14:50:02 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Oct 18, 2022, at 12:22 PM, Tim D=C3=BCsterhus wrote:

>>> Generating a random string containing specific characters...thus req=
uires multiple lines of code for what effectively is a very simple opera=
tion.
>>=20
>> Yeah, though those lines of code add distinction and emphasis for is
>> meant by character.
>>=20
>> In particular, users might be surprised when they give this string
>> "abc=F0=9F=98=8B=F0=9F=91=A8=E2=80=8D=F0=9F=91=A9=E2=80=8D=F0=9F=91=A6=
"* and get a non-ascii result.
>
> That's why the method includes 'bytes' in its name. This term is also=20
> used in ->shuffleBytes() which was renamed in=20
> https://wiki.php.net/rfc/random_extension_improvement due to this exac=
t=20
> problem.
>
> In fact ->shuffleBytes() can be considered the companion method to the=20
> proposed ->getBytesFromAlphabet():

"Alphabet" here still, to me, implies a character set, not a byte stream=
.  Maybe getBytesFromString?  getBytesFromList?  getBytesFrom() (because=
 you're getting it "from" the string that's provided, so you don't need =
another noun there.)?

I'm not opposed to the functionality, but "alphabet" doesn't seem like t=
he right word for it.

--Larry Garfield