Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118839
Message-ID: <a12d1750-8135-0896-81ad-a58a2d3f6c76@bastelstu.be>
Date: Tue, 18 Oct 2022 13:32:32 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Derick Rethans <derick@derickrethans.nl>, internals@lists.php.net,
 Tim Starling <tstarling@wikimedia.org>
References: <22177032-fe72-c39b-63fe-fa4368a70852@bastelstu.be>
 <ef9fa4be-09e7-56a3-9552-76ded6af2e87@wikimedia.org>
 <55F182F5-BA73-4224-BEE8-26C393078284@derickrethans.nl>
In-Reply-To: <55F182F5-BA73-4224-BEE8-26C393078284@derickrethans.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [VOTE] Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 10/18/22 09:32, Derick Rethans wrote:
>> If I'm reading the implementation correctly, the original exception
>> is thrown away, there's no way to get the
>> original message and backtrace.
>> That will make debugging more difficult.
> 
> I believe that is not true. It should be wrapped and accessible through ->previous on the exception.
> 

Correct, the original Exception/Error will be available using 
$e->getPrevious(). This is also explained in the RFC in the "Add wrapper 
Exception 'UnserializationFailedException'" section:

>  The original \Throwable will be accessible through the $previous property of \UnserializationFailedException, allowing the developer to learn about the actual cause of the unserialization failure by inspecting ->getPrevious(). 

This is not apparent from taking a cursory look at the diff of the 
native implementation in the pull request, because setting $previous 
will happen implicitly whenever native code throws an Exception, while 
an Exception is already "active".

Best regards
Tim Düsterhus