Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118832
MIME-Version: 1.0
References: <22177032-fe72-c39b-63fe-fa4368a70852@bastelstu.be>
 <CAOWwgpmuiRzUwGpU3ShQ7HOAVGhcP=Wb8z50acLfERMn_NEbwQ@mail.gmail.com>
 <c9e61189-7826-844f-56b9-7bb509a0791d@bastelstu.be> <CAOWwgpnpBTx9-aLz-bg1xZ9FT5JyWsX44TLwfvanDS_aAW7qdQ@mail.gmail.com>
 <c69c45f7-9836-1858-d90e-df7042bd3f88@bastelstu.be> <CAOWwgpmZ82zp7apmrwmb+xKOrwJvMuOJ=OMBuZa3n44ZPX5Uwg@mail.gmail.com>
In-Reply-To: <CAOWwgpmZ82zp7apmrwmb+xKOrwJvMuOJ=OMBuZa3n44ZPX5Uwg@mail.gmail.com>
Date: Mon, 17 Oct 2022 11:16:02 +0100
Message-ID: <CAJvSBVOiK0W+m4L6bUwTHRvnym9U8RqFJ82Kba+PKTPDLbOijw@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000067936405eb384539"
Subject: Re: [PHP-DEV] [VOTE] Improve unserialize() error handling
From: phpmailinglists@gmail.com (Peter Bowyer)

--00000000000067936405eb384539
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 17 Oct 2022 at 09:57, Nicolas Grekas <nicolas.grekas+php@gmail.com>
wrote:

> I created this patch/PR to show the changes that would be required on
> Symfony to work around the BC break:
> https://github.com/symfony/symfony/pull/47882
>
> Note to readers: in this whole discussion, Symfony is just an example of
> affected code. In the end, Symfony will adapt to the RFC if it passes. Th=
e
> point being made is that PHP scripts should not have to be patched to run
> on newer minor versions of PHP. That's what "keeping BC" means.
>

 I didn't think there was much reason for the negative fuss being made
around this PR, after all catching \Throwable or another exception doesn't
make much difference. Seeing the workarounds here however it is more
involved than I expected.

I have changed my vote for the first point to "No". I=E2=80=99d like to see=
 this
implemented in future (9.0?) but now agree that 8.3 isn=E2=80=99t the right=
 place.

Peter

--00000000000067936405eb384539--