Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118824
MIME-Version: 1.0
References: <CAEsg9X3LGYQiF6PGgfhY9s=4iD5v0u2scFRyekNtJfcKDMijtQ@mail.gmail.com>
 <CAAwFBqoG0wjRxVXC8FvBHv5uCJYVYNJWLEGTnAX7DiYUO3rpVQ@mail.gmail.com>
 <CABigaAU+eR718cEHUmwxNdBuMyQSwKkhnR2SfMo1otiMwrq+jg@mail.gmail.com>
 <EB5DD38F-6A46-4D07-B011-00179E91724C@cschneid.com> <CAEsg9X0DAh+Y45LUdG=aFOo4cWvmBU2Vfg48YcnsQkdh1grEdg@mail.gmail.com>
 <CALKiJKqcwkMW8Dw9Htxzt=Swkz08uY5XNEOrLq2qEsyTrJczTA@mail.gmail.com>
 <C45353A1-0666-4857-AC9F-99DA0BB90031@gmail.com> <1aa20877-3365-0ace-25d2-1cb1be8f3bcc@gmail.com>
 <55686BD4-4C67-4A4F-8BE4-BDF0149296FB@gmail.com> <e1626e1c-56ae-833f-0e6b-25f593f80caa@parentesigraffe.com>
In-Reply-To: <e1626e1c-56ae-833f-0e6b-25f593f80caa@parentesigraffe.com>
Date: Sat, 15 Oct 2022 16:22:13 +0200
Message-ID: <CA+kxMuSC=fr_25X8WKKr2XfSzzBh=4iNTNYNqZS_3hf5SiPgKA@mail.gmail.com>
To: Gianni Gentile <g.gentile@parentesigraffe.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Casting array to any class
From: Danack@basereality.com (Dan Ackroyd)

On Sat, 15 Oct 2022 at 13:14, Gianni Gentile
<g.gentile@parentesigraffe.com> wrote:
>
> What are your thoughts on introduce the `(AnyType)` cast to instantiate
> objects from associative array (or object properties also)?

It seems a pretty bad idea.

In particular, it makes for hard to maintain code as it doesn't give a
place for error checking to occur.

Though I do actually use that pattern in code. Below is a trait that
accomplishes it that should only be used in prototype code. Having it
as a trait means at least I can debug through the initialization and
see if it's missing properties from the array,

But in general, you'd really need to make a strong argument for why it
should be in core, not just why anyone would be against it.

cheers
Dan
Ack

trait FromArray
{
    /**
     * @param array $data
     * @return static
     * @throws \ReflectionException
     */
    public static function fromArray(array $data): self
    {
        $reflection = new \ReflectionClass(__CLASS__);
        $instance = $reflection->newInstanceWithoutConstructor();

        foreach ($instance as $key => &$property) {
            $property = $data[$key];
        }

        return $instance;
    }
}