Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118819
Message-ID: <97d8ecac-2249-81e4-fc01-9a02e5b5cf93@gmx.de>
Date: Sat, 15 Oct 2022 13:02:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>,
 =?UTF-8?Q?Tim_D=c3=bcsterhus?= <tim@bastelstu.be>
Cc: PHP internals <internals@lists.php.net>
References: <22177032-fe72-c39b-63fe-fa4368a70852@bastelstu.be>
 <CAOWwgpmuiRzUwGpU3ShQ7HOAVGhcP=Wb8z50acLfERMn_NEbwQ@mail.gmail.com>
 <c9e61189-7826-844f-56b9-7bb509a0791d@bastelstu.be>
 <CAOWwgpnpBTx9-aLz-bg1xZ9FT5JyWsX44TLwfvanDS_aAW7qdQ@mail.gmail.com>
In-Reply-To: <CAOWwgpnpBTx9-aLz-bg1xZ9FT5JyWsX44TLwfvanDS_aAW7qdQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] Improve unserialize() error handling
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 15.10.2022 at 11:06, Nicolas Grekas wrote:

>>> I'm therefore voting NO on the proposal.
>>
>> I'm not surprised by the =E2=80=9Cno=E2=80=9D on the first vote based o=
n the previous
>> discussion. I am surprised however that you also disagree with raising
>> the E_NOTICE to E_WARNING for consistency.
>
> Since the beginning my point is not that the RFC doesn't have merits. It=
's
> that the proposed approach breaks BC in a way that will affect the
> community significantly. We have policies that say we should avoid BC
> breaks and they should apply here.

Well, I consider the current behavior very unfortunate; sometimes
E_NOTICE, sometimes E_WARNING, sometimes both, and sometimes a
UnexpectedValueException =E2=80=93 and this looks more like historic rando=
mness
than having any deeper reasoning behind it.  I also understand that we
need to be concerned about BC breaks.

So for me the question is whether we want to stick with the current
behavior *forever*, or if there is an acceptable way forward.  I
certainly hope for the latter.  Would it really be a serious issue to
promote E_NOTICE to E_WARNING in PHP 8.3?  I don't think so, but I may
be wrong.

And would it really be a serious issue to promote E_WARNING to an
exception in PHP 9?  Maybe, but after all that would be a new major
version, so some BC breaks are to be expected anyway.

=2D-
Christoph M. Becker