Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118812
MIME-Version: 1.0
References: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de>
In-Reply-To: <5ceebae4-a3fb-5d29-cdb7-dceed7b07c78@wcflabs.de>
Date: Fri, 14 Oct 2022 07:32:34 +0300
Message-ID: <CAAwdEzCVokPfcavL6ygrQqXmfBEcaSG-tYOnkXhTMJmj7j8q1g@mail.gmail.com>
To: =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>, tim@bastelstu.be
Content-Type: multipart/alternative; boundary="0000000000002efcea05eaf71e14"
Subject: Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000002efcea05eaf71e14
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 13, 2022, 22:37 Joshua R=C3=BCsweg via internals <
internals@lists.php.net> wrote:

> Hi
>
> Tim D=C3=BCsterhus and I have created an RFC to add new methods that solv=
e
> commonly encountered use cases to \Random\Randomizer. Specifically
> creating a random string consisting of specific bytes and generating
> random floating point values.
>
> You can find the RFC at:
>
> https://wiki.php.net/rfc/randomizer_additions
>
> Proof of concept implementation is in:
>
> * https://github.com/php/php-src/pull/9664
> * https://github.com/php/php-src/pull/9679
>
>
>
> Some open questions to start the discussion:
>
> * Are you missing other commonly useful operations that are also useful
> to have in core?
>

For completeness, it would be good to have nextBool() as well.

* Do you agree with the method names? Within the PR we received comments
> that "alphabet" might not be an appropriate term.
>

Yes, alphabet is fine by me but I can suggest also: character set,
character list, character dictionary, byte set, byte list, byte dictionary
or some shortcuts of it, like charset.

* Shall an option be added to getFloat() that changes the logic to
> select from [$min, $max] (i.e. allowing the maximum to be returned)? And
> how should that look like? Boolean parameter? Enum?
>

No, IMO. Mathematically it doesn't really make sense and talking about
floats, it will also be a very corner case not reached in tests that might
happen in production rarely and break things.


> ----
>
> We're looking forward to your feedback.
>
>
> Cheers
>
> Joshua R=C3=BCsweg
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>

>
>
I am having another small issue.
As the Randomizer class is final, I guess this will not be perfectly
polyfillable in userland.
So... , if accepted, would it be completely wrong to have these new methods
in PHP 8.2? What can it break?

--0000000000002efcea05eaf71e14--