Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118807
Message-ID: <c66178e4-cf5e-b36c-5ee1-6b1f9bfc6c0a@bastelstu.be>
Date: Wed, 12 Oct 2022 19:30:26 +0200
MIME-Version: 1.0
Content-Language: en-US
To: "Christoph M. Becker" <cmbecker69@gmx.de>,
 Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
 <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
 <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
 <d27551ce-78da-49b1-8531-41c2d5e97036@www.fastmail.com>
 <76b3ab60-8865-a0aa-3949-f9276cd35149@bastelstu.be>
 <720bc406-78f1-4f4f-b0fa-00c6eb541523@app.fastmail.com>
 <5c02132b-59b7-81dc-bd9f-a9d9210f7721@gmx.de>
 <d71e16d8-58e4-3d49-dd64-b77795545c0a@bastelstu.be>
In-Reply-To: <d71e16d8-58e4-3d49-dd64-b77795545c0a@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/28/22 17:42, Tim Düsterhus wrote:
>>> If you want to go that route, I'd go all the way to an RCV vote and be done with it.  Or else just make an executive decision as the RFC author and let the chips fall where they may.
>>
>> I'm generally not too happy with secondary votes.  Sometimes you only
>> support the primary vote for certain secondary options; to "be sure"
>> that another secondary option won't "win", you'd need to vote "no" on
>> the primary choice.
>>
>> I'd prefer a single vote with pre-selected details.  I don't have any
>> particular preference in this case, though.
>>
> 
> Would the increase of E_NOTICE to E_WARNING for the two cases that
> currently emit E_NOTICE be something that even requires a vote or is
> this something that can simply be decided by merging a PR? [1] In that
> case the second and third vote could be simplified to "Convert E_* to
> Exception" with the regular 2/3 majority required.

As I've been told that the E_NOTICE to E_WARNING also requires a vote, 
I've thought about this whole matter a little more, because I agree with 
Christoph that secondary votes are "not great".

In the end I've decided to make this all primary votes that more or less 
build on each other, each requiring a 2/3 majority. The vote to change 
E_NOTICE/E_WARNING to Exception in 8.3 was dropped to keep thing simpler 
and to not have conflicting votes. Instead there is only "Unify to 
E_WARNING in 8.x" and "Upgrade to Exception in 9.0" (which may happen 
independently of whether the E_NOTICE will remain in 8.x).

That said: Discussion has come to a halt and I don't plan any more 
changes to the proposal. As such I plan to open voting on Friday with 
the voting widgets as they are currently within the RFC:

https://wiki.php.net/rfc/improve_unserialize_error_handling#proposed_voting_choices

Best regards
Tim Düsterhus