Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118694
Message-ID: <76b3ab60-8865-a0aa-3949-f9276cd35149@bastelstu.be>
Date: Tue, 27 Sep 2022 22:01:35 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
 <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
 <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
 <d27551ce-78da-49b1-8531-41c2d5e97036@www.fastmail.com>
In-Reply-To: <d27551ce-78da-49b1-8531-41c2d5e97036@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/8/22 18:36, Larry Garfield wrote:
>>> Either I guess?  Honestly we should decide that in advance on the list. :-)  E_WARNING+Exception in 9 is what I'd probably favor, with "Exception now" as a second choice.
>>>
> We've done this kind of two-step thing before; a lot of PHP 8 changes were voted on well in advance of 8.0's release.  A "Warning now, Exception in 9" vote would not be unprecedented.
> 

Thank you, I thought about what to do here and I've adjusted the options 
in the "increase to what" vote to make this a 3-way vote:

https://wiki.php.net/rfc/improve_unserialize_error_handling#increasing_the_severity_of_existing_warningsnotices

Do you believe that my reasoning with regard to the interpretation of 
the vote's results is sound? A ranked choice vote should not necessary 
here, because the three options follow a natural order with regard to 
severity/possible breakage.

Best regards
Tim Düsterhus