Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118688
MIME-Version: 1.0
References: <CADU7aoswehMbnD5CnnaeeZAhvQqWCMrPGaug++7s32aXphN3jQ@mail.gmail.com>
In-Reply-To: <CADU7aoswehMbnD5CnnaeeZAhvQqWCMrPGaug++7s32aXphN3jQ@mail.gmail.com>
Date: Thu, 22 Sep 2022 15:15:06 +0200
Message-ID: <CAOwTYAsCr1RC++rEN3aVPoyaPoy0et9uhkXf3XG+43JV=Cc96A@mail.gmail.com>
To: kevin@dunglas.dev
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000440b5f05e943dad6"
Subject: Re: [PHP-DEV] Set SA_ONSTACK in zend_sigaction External
From: krakjoe@gmail.com (Joe Watkins)

--000000000000440b5f05e943dad6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Kevin,

Master should be targeted, no RFC is required, and the patch looks fine to
me.

Cheers
Joe

On Thu, 22 Sep 2022, 14:56 K=C3=A9vin Dunglas, <kevin@dunglas.dev> wrote:

> Hi, internals!
>
> It's been a while.
>
> I'm currently working on a new SAPI for web servers written in Go.
> Many virtual machines, including Go (
> https://pkg.go.dev/os/signal#hdr-Go_programs_that_use_cgo_or_SWIG), depen=
d
> on signals using SA_ONSTACK (
> https://man7.org/linux/man-pages/man2/sigaltstack.2.html). This flag
> allows
> a thread to define a new alternate signal stack. Many argue that SA_ONSTA=
CK
> should be a default, but it's not the case (yet).
>
> Python merged a patch setting SA_ONSTACK in 2021 (Python 3.10+) for the
> same reasons (https://bugs.python.org/issue43390 /
>
> https://github.com/python/cpython/commit/02ac6f41e5569ec28d625bb005155903=
f64cc9ee
> ),
> with no issues.
>
> I opened a Pull Request to set this flag by default and tested it
> successfully with my Go SAPI: https://github.com/php/php-src/pull/9597
>
> As this is technically at the limit between a new feature and a bug fix
> (having the ability to call Go/C++ VM code from PHP and embed PHP in such
> programs), should I open an RFC? Also, if merging my patch is considered,
> which branch should I target?
>
> Cheers,
> --
> K=C3=A9vin Dunglas
>

--000000000000440b5f05e943dad6--