Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118683
Message-ID: <a81f09a3-0f3d-86a5-b9b4-a097ce49da28@bastelstu.be>
Date: Wed, 21 Sep 2022 18:10:36 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: internals@lists.php.net
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <CAOWwgpnQuRMv4Uv=bM+QNBPeUC8BCk4f1kYOcg8EUrYD1WoRzQ@mail.gmail.com>
 <51a57a4d-ccb5-a581-205e-e2684e4db8c8@bastelstu.be>
 <CAOWwgp=W94c4Vzkn7HZkzWESjaE6bm8yCUGTD1+X1eiHQsCTjw@mail.gmail.com>
 <81f1ceb4-1086-3f1a-942d-aebbb5c2712f@bastelstu.be>
 <CAOWwgpko4i=Af6ybAy+p5N7zEjGnWhh+ZCxYy6=nJ7J7k+KJVw@mail.gmail.com>
 <94b9c2ab-70d5-48e1-50f8-409a3073023a@bastelstu.be>
In-Reply-To: <94b9c2ab-70d5-48e1-50f8-409a3073023a@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/20/22 21:24, Tim Düsterhus wrote:
> My understanding is that this attempts to gracefully handle broken cache
> entries and force a rebuild if the payload is invalid.
> 
> This will fail if the serialized payload contains a malformed
> DateTimeImmutable, because DateTimeImmutable will throw an Error,
> instead of Exception: https://3v4l.org/eB5ZE. The 'catch' should likely
> be adjusted to catch '\Throwable'.
> 

To add onto this: "An Error could be thrown" might also happen with a 
PHP 8.2 readonly class that later removes a property. As the property no 
longer exists on the class it will be considered a dynamic property 
which is disallowed on readonly classes, thus throwing an 'Error', not 
'Exception' during unserialization:

https://3v4l.org/Xsmfu

Best regards
Tim Düsterhus